675618 - Crash during startup on ARM when linked with recent GNU ld

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mike Hommey [:glandium]]

Thanks to this GNU ld bug: http://sourceware.org/bugzilla/show_bug.cgi?id=13049 , building with a recent GNU ld (>= 2.21.1 are affected for sure, not sure about older ones ; 2.19 is definitely not affected) on ARM leads to a crash.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

A workaround is to avoid using variables with a name starting with "stub".

js/src/jsdhash.cpp has the same variable name, but as it is compiled as C++, its name is mangled and thus doesn't start with "stub".

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Can we use gold for this?

Comment 3

[Mike Hommey [:glandium]]

(In reply to comment #2)
> Can we use gold for this?

It's not only a problem for us. It's a problem for those that use GNU ld on ARM.

Comment 4

[Benjamin Smedberg]

Comment on attachment 549783 [details] [diff] [review]
Work around recent ARM GNU ld bug with -fdata-sections and variables names starting with "stub" leading to crash

Since pldhash is jsdhash, can we just compile it as C++ and move on?

Comment 5

[Mike Hommey [:glandium]]

Attachment: Compile pldhash as C++

> Since pldhash is jsdhash, can we just compile it as C++ and move on?

We can.

Comment 6

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3d20269baeee

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/3d20269baeee

Comment 8

[Daniel Holbert [:dholbert]]

For the record, this requires a clobber to build successfully, or else you'll get errors like:
> make[8]: *** No rule to make target `pldhash.c', needed by `pldhash.o'.  Stop.

(noting here in case any devs / projec-branch-owners encounter this error and do a bugzilla search to see if it's reported anywhere)