675711 - test_computed_style.html fails partly on Fennec because of lack of scrollbars

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: patch

Firefox has scrollbars and this test assumes scrollbars, which makes the border-radius much smaller (the border width). But Fennec doesn't have scrollbars, so the border-radius isn't clamped at all for overflow:scroll frames. Hence the failing tests there.
The attached patch corrects it.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Where does the " - 10" come from?  Is that the width of a scrollbar for you?  If so, shouldn't the test be == 0, and for the other branch (or just ==, without -)?

Also, the text probably shouldn't say "clamped" when there's actually no clamping.

Comment 2

[Martijn Wargers (dead)]

Attachment: patch

The 10 comes from the border-width (5px on both sides), which is not included in the clientWidth value.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 549897 [details] [diff] [review]
patch

r=dbaron

Comment 4

[Martijn Wargers (dead)]

Attachment: patch

One change from the previous patch:
Instead of:
  if (p.clientWidth == p.offsetWidth - 10) {
I now use this:
  if (p.clientHeight == p.offsetHeight - 10) {
for overflow-X scroll divs.

Stupid mistake. Instead of only testing this mochitest on Fennec, I should have tested on Firefox too, of course.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

all green on try server, pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fbf02dd1803e

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/fbf02dd1803e