676013 - L10nVerify is giving a setupBuild exception

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

2011-08-02 10:33:57-0700 [Broker,10545,10.250.50.152] Build.setupBuild failed
2011-08-02 10:33:57-0700 [Broker,10545,10.250.50.152] Unhandled Error
	Traceback (most recent call last):
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/twisted/internet/defer.py", line 318, in callback
	    self._startRunCallbacks(result)
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/twisted/internet/defer.py", line 424, in _startRunCallbacks
	    self._runCallbacks()
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/twisted/internet/defer.py", line 441, in _runCallbacks
	    self.result = callback(self.result, *args, **kw)
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/buildbot-0.8.2_hg_3dc678eecd11_production_0.8-py2.6.egg/buildbot/process/builder.py", line 901, in _startBuild_2
	    d = build.startBuild(bs, self.expectations, sb)
	--- <exception caught here> ---
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/buildbot-0.8.2_hg_3dc678eecd11_production_0.8-py2.6.egg/buildbot/process/base.py", line 217, in startBuild
	    self.setupBuild(expectations) # create .steps
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/buildbot-0.8.2_hg_3dc678eecd11_production_0.8-py2.6.egg/buildbot/process/base.py", line 272, in setupBuild
	    step = factory(**args)
	  File "/builds/buildbot/build1/lib/python2.6/site-packages/buildbotcustom/steps/release.py", line 33, in __init__
	    self.super_class.__init__(self, ignoreCodes=[0,1], **kwargs)
	exceptions.TypeError: __init__() got multiple values for keyword argument 'ignoreCodes'

Looks like this might be due to bug 538541 and needing a restart on the master instead of a reconfig? Need to test this on staging.

Comment 1

[Rail Aliiev [:rail]]

Attachment: fix initialization

New and recommended addStep style initializes factories in a little bit different way. 

dump of kwargs before calling parent's init (runtime):

{'lazylogfiles': False, 'workdir': 'tools/release/l10n', 'description': None, 'descriptionDone': None, 'logfiles': {}, 'command': None, 'ignoreCodes': [0, 1], 'usePTY': 'slave-config', 'log_eval_func': None}

<dustin> rail: because ignoreCodes is already in kwargs at that point
<dustin> instead of passing that explicitly to thep arent class
<dustin> you should add it to kwargs
<dustin> kwargs['ignoreCodes'] = [0,1]
<dustin> before upcalling to the parent

Additionally need to use "if not kwargs.get('command')" instead of "if not 'command' in kwargs" for the same reason.

Worked in staging.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 550309 [details] [diff] [review]
fix initialization

most excellent. thanks for taking this.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 550309 [details] [diff] [review]
fix initialization

http://hg.mozilla.org/build/buildbotcustom/rev/d76595b99f4e

Comment 4

[Rail Aliiev [:rail]]

All done here.