676240 - Crash [@ nsXULTreeAccessible::GetChildCount()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[jon]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

my firefox 5.0 crashes on random websites and i need to restart it over and over


Actual results:

browsesing to a website


Expected results:

it shouldn't crash all day long

Comment 1

[jon]

i have submitted bug after bug after bug and it doesn't seem like anything is happening

Comment 2

[Robert Longson [:longsonr]]

Please provide the crash report IDs from about:crashes from some of your recently submitted crashes.

Comment 3

[jon]

https://crash-stats.mozilla.com/report/index/81835928-14e5-4e38-ad99-3073c2110707

Comment 4

[Thomas Ahlblom]

0 	xul.dll 	nsXULTreeAccessible::GetChildCount 	accessible/src/xul/nsXULTreeAccessible.cpp:452
1 	xul.dll 	nsAccessibleWrap::get_accChildCount 	accessible/src/msaa/nsAccessibleWrap.cpp:239
2 	rpcrt4.dll 	Invoke 	
3 	rpcrt4.dll 	NdrStubCall2 	
4 	rpcrt4.dll 	NdrClientMapCommFault 	
5 	oleaut32.dll 	oleaut32.dll@0x129ae 	
6 	ole32.dll 	SyncStubInvoke 	
7 	ole32.dll 	StubInvoke 	
8 	ole32.dll 	IFillLockBytes_FillAppend_Proxy 	
9 	ole32.dll 	COIDHashTable::Compare

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

Per http://bit.ly/p4W3hE this happens on Firefox 5/6/7/8 Branches.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 7

[Trevor Saunders (:tbsaunde)]

Comment on attachment 550434 [details] [diff] [review]
patch


>+  if (!pcountChildren)
>+    return E_INVALIDARG;
>   *pcountChildren = 0;

blank line after return please.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to comment #7)

> >+  if (!pcountChildren)
> >+    return E_INVALIDARG;
> >   *pcountChildren = 0;
> 
> blank line after return please.

sure if you like

Comment 9

[alexander :surkov (:asurkov)]

inbound land http://hg.mozilla.org/integration/mozilla-inbound/rev/0e7f85aa8137

Comment 10

[alexander :surkov (:asurkov)]

landed http://hg.mozilla.org/mozilla-central/rev/0e7f85aa8137