676455 - modutils fails to build with undefined references recent gold or ld --no-add-needed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

according to gladium gcc4.6 dropped -lz from its default libs, so you get:

jarfile.c:429: error: undefined reference to 'inflateInit2_'
jarfile.c:441: error: undefined reference to 'inflate'
jarfile.c:448: error: undefined reference to 'inflateEnd'
jarfile.c:342: error: undefined reference to 'inflateInit2_'
jarfile.c:379: error: undefined reference to 'inflate'
jarfile.c:398: error: undefined reference to 'inflateEnd'

Comment 1

[Mike Hommey [:glandium]]

Full analysis is in bug 676319. But since this one has a patch...

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 550596 [details] [diff] [review]
patch

Review of attachment 550596 [details] [diff] [review]:
-----------------------------------------------------------------

This actually isn't Android specific, and considering bug 580679 comment 18, -lz is probably not the solution either.

Comment 4

[Mike Hommey [:glandium]]

So this actually is Android specific, because OS_LIBS is cleared to avoid it containing -lpthread, which Android doesn't have. The effect is that it effectively prevents modutil's Makefile to add ZLIB_LIBS in that variable, thus the build failure. We can't add -lz to all link commands in NSS... but there's maybe an easy way out. Is modutil actually used at all? Do we really need to build it for Android, or at all?

Comment 5

[Mike Hommey [:glandium]]

(In reply to comment #4)
> Is modutil actually used at all? Do we really
> need to build it for Android, or at all?

It's apparently only used for nss tests, and I doubt we run them on Android.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Don't fail to build NSS's modutil on Android

This works properly. We don't need the fallback to MOZ_ZLIB_LIBS for MOZ_NATIVE_ZLIB because in that case, with the remaining change from bug 580679 that should land, we would fall on the non USE_SYSTEM_ZLIB="" case, which does put ZLIB_LIBS in EXTRA_LIBS instead of OS_LIBS in nss/cmd/modutil/Makefile.

(And we do build with system zlib on android, anyway)

The real fix would be to get rid of -lpthread on android in the nss build system, and remove the hacks from security/manager, but we all know how long that takes.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Don't fail to build NSS's modutil on Android

When looking how to fix the root problem in nss itself, I saw that we don't actually need to override OS_LIBS to remove -lpthread from it. All we need is to override OS_PTHREAD.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Don't fail to build NSS's modutil on Android

with an update to the comment this time.

Comment 9

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/51c305f11c13

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/51c305f11c13