676701 - Previous panel bleeds into the next one in the promo module

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Previous panel bleeds into the next one in the promo module. More obvious within the add-ons manager. See screenshot

Comment 1

[Potch [:potch]]

oh no white space!

Comment 2

[Potch [:potch]]

looks like it was introduced here: https://github.com/jbalogh/zamboni/commit/c9fa656c7c69c29bea5b739b49d461bb1f708171#L1R46

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to Matt Claypotch [:potch] from comment #1)
> oh no white space!

Can we make this any more resilient?

Comment 4

[Potch [:potch]]

I don't think it needs resiliency, honestly. It's no different than botching a margin or padding, or a typo in code- we just need to pay attention. I will document this particular issue in the code so people touching it are more caeeful, and check that their changes haven't regressed things.

Comment 5

[Jeff Balogh (:jbalogh)]

Significant whitespace in between blocks of HTML is a bit different than a typo.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/bbc3fe8

Comment 7

[krupa raj[:krupa]]

verified fixed at https://addons.allizom.org/en-US/firefox/discovery/pane/5.0.1/Darwin