677423 - Add togglePrivateBrowsing() to head.js

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

This is now used in a lot of Panorama tests and we should move this to head.js instead of having duplicates.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 551633 [details] [diff] [review]
patch v1

Looks good

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 551633 [details] [diff] [review]
patch v1

>+function togglePrivateBrowsing(callback) {
>+  if (callback) {

This probably shouldn't be called without a callback.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

(In reply to Dão Gottwald [:dao] from comment #3)
> >+function togglePrivateBrowsing(callback) {
> >+  if (callback) {
> 
> This probably shouldn't be called without a callback.

Agreed.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 551712 [details] [diff] [review]
patch v2

>--- a/browser/base/content/test/tabview/browser_tabview_bug624727.js
>+++ b/browser/base/content/test/tabview/browser_tabview_bug624727.js
>@@ -58,18 +58,17 @@ function test() {
>     assertOneTabInGroup(prefix, group1);
>     assertOneTabInGroup(prefix, group2);
>   }
> 
>   let testStateAfterEnteringPB = function () {
>     let prefix = 'enter';
>     ok(!pb.privateBrowsingEnabled, prefix + ': private browsing is disabled');
>     registerCleanupFunction(function () {
>-      if (pb.privateBrowsingEnabled)
>-        pb.privateBrowsingEnabled = false
>+      pb.privateBrowsingEnabled = false

lacks a semicolon

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/3a90c0752436

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/3a90c0752436