Closed Bug 6776 Opened 25 years ago Closed 25 years ago

bookmarks.js tries to load container URLs

Categories

(Core Graveyard :: RDF, defect, P3)

Product:
Core Graveyard
Component:
RDF
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mozilla, Assigned: slamm)

Details

The OpenURL() function in mozilla/rdf/resources/bookmarks.js is wrong; clicking
on a container in the sidebar should never try to open up the URL! Here's a
corrected version of what should be done (with the improper JavaScript commented
out.)

function OpenURL(event,node)
{
/*
  ***** NEVER check against the type! *****

  if (node.getAttribute('type') !=
      "http://home.netscape.com/NC-rdf#Bookmark") {
    return false;
  }
*/

  /* DO check to see whether the item is a container */
  if (node.getAttribute('container') == "true")
  {
    return false;
  }
Target Milestone: M6
I'm setting the target milestone for this to M6 as its a trivial fix.  :^)
Status: NEW → ASSIGNED
I will check it in as soon as I get approval.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Thank you for the fix Robert. I checked it in.
Marking FIXED.
Status: RESOLVED → VERIFIED
code level fix - i'm marking this verified. if you object, robert, please
reopen...
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.