677644 - Fix c++0x initializer list error found by clang

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: add cast

The process_id field is unsigned, so we need this cast in c++0x. Let me know if you would like me to try to make the field signed instead.
See http://llvm.org/viewvc/llvm-project/?view=rev&revision=136181
for more information.

Comment 1

[Mark Mentovai]

Committed Breakpad r825.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 551848 [details] [diff] [review]
add cast

Feel free to land this in m-c as well.

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2012711170aa

It looks like the commit message in the attached patch included a chunk of the bug description. ("The process_id field is unsigned, so we need this cast in c++0x. Let me know if you would like me to try to make the field signed instead.
See http://llvm.org/viewvc/llvm-project/?view=rev&revision=136181
for more information.")

I trimmed it, but it'd be helpful if you could make sure the commit message in checkin-needed patches was more commit-message-ish. :)

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/2012711170aa