Closed
Bug 677646
Opened 13 years ago
Closed 13 years ago
Install Add-on from file no longer works
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla8
Tracking | Status | |
---|---|---|
firefox8 | - | --- |
People
(Reporter: ilatypov, Assigned: Unfocused)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
4.03 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110809 Firefox/8.0a1 Build ID: 20110809030751 Steps to reproduce: Removed my Lightning comm-central add-on, attempted to install it from a fresh file. Actual results: After choosing the fresh file with the add-on manager file picker, the add-on screen did not update. I observed an error in Error Console, Error: win is null Source File: chrome://messenger/content/specialTabs.js Line: 1065 This pointed to the last line in the following code from omni.jar!/chrome/messenger/content/messenger/specialTabs.js, xpInstallObserver: { observe: function (aSubject, aTopic, aData) { const Ci = Components.interfaces; let brandBundle = document.getElementById("bundle_brand"); let messengerBundle = document.getElementById("bundle_messenger"); let installInfo = aSubject.QueryInterface(Ci.amIWebInstallInfo); let win = installInfo.originatingWindow; let notificationBox = getNotificationBox(win.top); I changed "win" with "window" and the Javascript error disappeared, but I still could not see any feedback from my attempt to install the add-on. Expected results: Either a pop-up window should provide reasons for not installing the add-on, or the add-on list should update and the new add-on should highlight.
Updated•13 years ago
|
tracking-thunderbird8:
--- → ?
Reporter | ||
Comment 1•13 years ago
|
||
(a) I figured that the bug occurs only when attempting to install an incompatible Lightning build from its top-level download directory, http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/win32-xpi/ as opposed to the proper build in the latest-comm-central sub-directory, http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-central/win32-xpi/ (b) The bug does NOT occur with an August 2 nightly build of Shredder, http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2011-08-02-03-01-33-comm-central/ The bug occurs with all subsequent builds such as the one from the next night, http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2011-08-03-03-01-08-comm-central/
Reporter | ||
Updated•13 years ago
|
Summary: latest-comm-central-trunk fails to install add-ons → nightly builds of latest-comm-central-trunk after August 2 fail to inform on incompatible add-ons
Reporter | ||
Updated•13 years ago
|
Summary: nightly builds of latest-comm-central-trunk after August 2 fail to inform on incompatible add-ons → nightly builds of latest-comm-central after August 2 fail to inform on incompatible add-ons
Comment 2•13 years ago
|
||
Igor is Firefox nightly behaving the same way ?
Comment 3•13 years ago
|
||
I've just tested Firefox - installing an incompatible add-on from a file causes exactly the same failure. Given the regression range, my best bet is bug 670023 being the one that caused this. STR: 1) Find an add-on incompatible with current trunk and download it to disk 2) Go to Tools -> Add-on Manager and then select the menu with Install Add-on from File. 3) Nothing happens. See comment 0 for the errors on the error console (similar code for FF).
Blocks: 670023
Severity: normal → major
Status: UNCONFIRMED → NEW
tracking-thunderbird8:
? → ---
Component: General → Add-ons Manager
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
Product: Thunderbird → Toolkit
QA Contact: general → add-ons.manager
Hardware: x86 → All
Summary: nightly builds of latest-comm-central after August 2 fail to inform on incompatible add-ons → Install Add-on from file no longer works
Version: Trunk → 8 Branch
Comment 4•13 years ago
|
||
Blair can you either figure this out or backout the strict mode patch before the merge on Tuesday
Assignee: nobody → bmcbride
Updated•13 years ago
|
tracking-firefox8:
--- → ?
Assignee | ||
Comment 5•13 years ago
|
||
Simple fix. Testing it, however, is another story. Would like to punt that to a litmus test. (Fwiw, it was only the browser notification that was broken - it still installed fine.)
Attachment #553097 -
Flags: review?(dtownsend)
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 6•13 years ago
|
||
Comment on attachment 553097 [details] [diff] [review] Patch v1 Could you test this by at least verifying that the observer notifications are getting sent?
Attachment #553097 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Indirectly testing via observer notifications.
Attachment #553097 -
Attachment is obsolete: true
Attachment #553356 -
Flags: review?(dtownsend)
Updated•13 years ago
|
Attachment #553356 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 8•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/67142b6a15ab
Flags: in-testsuite+
Flags: in-litmus?(hskupin)
Whiteboard: [inbound]
Updated•13 years ago
|
Flags: in-litmus?(hskupin) → in-litmus?(vlad.mozbugs)
http://hg.mozilla.org/mozilla-central/rev/67142b6a15ab
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Comment 10•13 years ago
|
||
litmus test for 6.0 branch https://litmus.mozilla.org/show_test.cgi?id=25824 litmus test for aurora branch https://litmus.mozilla.org/show_test.cgi?id=25825
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Target Milestone: mozilla8 → ---
Updated•13 years ago
|
Flags: in-litmus?(vlad.mozbugs) → in-litmus+
Updated•13 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Comment 11•13 years ago
|
||
(In reply to Maniac Vlad Florin (:vladmaniac) from comment #10) > litmus test for 6.0 branch https://litmus.mozilla.org/show_test.cgi?id=25824 > litmus test for aurora branch > https://litmus.mozilla.org/show_test.cgi?id=25825 Those tests are duplicates of a test I have added a while back. Not sure why those have been added again. https://litmus.mozilla.org/show_test.cgi?id=15218 I have removed both new tests.
Comment 12•13 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #3) > 1) Find an add-on incompatible with current trunk and download it to disk > 2) Go to Tools -> Add-on Manager and then select the menu with Install > Add-on from File. > 3) Nothing happens. Those steps work fine for me now with incompatible extensions and Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0a2) Gecko/20110824 Firefox/8.0a2
Status: RESOLVED → VERIFIED
Comment 13•13 years ago
|
||
This seems to have made Aurora. Do we actually need to track this.
Assignee | ||
Comment 14•13 years ago
|
||
(In reply to Asa Dotzler [:asa] from comment #13) > This seems to have made Aurora. Do we actually need to track this. I don't think so - it mainly affected other XULRunner applications, where Install from File may be the main method of installing addons (which isn't the case for Firefox).
Comment 15•13 years ago
|
||
(In reply to Blair McBride (:Unfocused) from comment #14) > I don't think so - it mainly affected other XULRunner applications, where > Install from File may be the main method of installing addons (which isn't > the case for Firefox). Even under this principle we have to ensure it's working in Toolkit. But since this fix landed for Firefox 8 and the strict mode has been enabled starting with Firefox 8, we should indeed be ok here.
Comment 16•13 years ago
|
||
---------------------------------[ Triage Comment ]--------------------------------- This looks like it already landed for Firefox 8 when it was on mozilla-central so we don't need to track.
You need to log in
before you can comment on or make changes to this bug.
Description
•