Closed
Bug 677787
Opened 13 years ago
Closed 13 years ago
Remove unique_pointer from typelib code
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: khuey, Assigned: emorley)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
7.26 KB,
patch
|
Details | Diff | Splinter Review |
It's completely unused.
Assignee | ||
Comment 1•13 years ago
|
||
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 554032 [details] [diff] [review] Patch v1 Does typelib.py not need adjustments here?
Attachment #554032 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2) > Does typelib.py not need adjustments here? Ah yes, the comments there can be removed too. Didn't show up in my local grep since I ran it from xpcom/typelib/ only, since MXR doesn't show occurrences in typelib.py due to out of date indexes :-(
Assignee | ||
Comment 4•13 years ago
|
||
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=da307e32d0c2
Attachment #554032 -
Attachment is obsolete: true
Assignee | ||
Comment 5•13 years ago
|
||
New try push due to random tree breakage that was going on at the time: http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=f701ded4c303 (That will teach me to pull from m-c tip when sending to try) Like the other checkin-needed's I'll likely just do these myself once IT flip my L3 bits in bug 680448.
Comment 6•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/d5514e9dd45c
Keywords: checkin-needed
Target Milestone: --- → mozilla9
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d5514e9dd45c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 8•13 years ago
|
||
Added a note to Firefox 9 for developers; since unique pointers appear never to have been fully implemented (let alone used), they were never documented, so this seems to be the most that needs doing (indeed it probably doesn't need mentioning at all).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•