Closed Bug 677787 Opened 13 years ago Closed 13 years ago

Remove unique_pointer from typelib code

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: khuey, Assigned: emorley)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #554032 - Flags: review?(khuey)
Comment on attachment 554032 [details] [diff] [review]
Patch v1

Does typelib.py not need adjustments here?
Attachment #554032 - Flags: review?(khuey) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Does typelib.py not need adjustments here?

Ah yes, the comments there can be removed too. Didn't show up in my local grep since I ran it from xpcom/typelib/ only, since MXR doesn't show occurrences in typelib.py due to out of date indexes :-(
New try push due to random tree breakage that was going on at the time:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=f701ded4c303

(That will teach me to pull from m-c tip when sending to try)

Like the other checkin-needed's I'll likely just do these myself once IT flip my L3 bits in bug 680448.
Flags: in-testsuite-
Keywords: checkin-needed
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/d5514e9dd45c
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Added a note to Firefox 9 for developers; since unique pointers appear never to have been fully implemented (let alone used), they were never documented, so this seems to be the most that needs doing (indeed it probably doesn't need mentioning at all).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: