Closed Bug 677924 Opened 13 years ago Closed 13 years ago

JS shell: version(4096) asserts

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(1 file)

      No description provided.
Attached patch v1Splinter Review
http://quotes.burntelectrons.org/4833
Assignee: general → jorendorff
Attachment #552098 - Flags: review?(cdleary)
The essential thing is to reject values >= 4096 with an exception; the rest is just me trying to get Version use the API correctly.

Incidentally that test where I added a Number() call was never doing what it thought it was doing, because version() would just ignore the string arguments.
Attachment #552098 - Flags: review?(cdleary) → review+
Merged:
http://hg.mozilla.org/mozilla-central/rev/7ae3174c57ff
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: Other Branch → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: