Closed
Bug 678028
Opened 13 years ago
Closed 13 years ago
Fix c++0x initializer list error found by clang
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(2 files)
27.98 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
3.74 KB,
text/plain
|
Details |
Fix build with clang in c++0x mode. In c++0x mode it is not valid to have an integer that doesn't fit a type in an initializer list. This patch just writes the constants as explicitly signed instead of using unsigned constants with 2 complement.
Attachment #552198 -
Flags: review?(mh+mozilla)
Updated•13 years ago
|
Attachment #552198 -
Flags: review?(mh+mozilla) → review?(joe)
Comment 1•13 years ago
|
||
Comment on attachment 552198 [details] [diff] [review] fix build Review of attachment 552198 [details] [diff] [review]: ----------------------------------------------------------------- Add the bug number to your checkin comment, and plz to attach source of the program you used to create this ;)
Attachment #552198 -
Flags: review?(joe) → review+
Assignee | ||
Comment 2•13 years ago
|
||
What I did was run with program 4 times, each time with one of the tables and copy and paste them into the original files.
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8f315a50dcc9
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Updated•13 years ago
|
Assignee: nobody → respindola
You need to log in
before you can comment on or make changes to this bug.
Description
•