678201 - [jsdbg2] Use CallArgs throughout Debugger.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Per bug 672829 comment 69.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: part 1 - preliminary - v1

The CheckThis code is fake generality. It turns out only one class uses it. So I go ahead and specialize it.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: part 2 - move - v1

Move the newly specialized code just before its first use.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: part 3 - Debugger - v1

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: part 4 - Script - v1

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: part 5 - Frame - v1

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: part 6 - Object - v1

That's it, 6 patches. It looks nicer this way.

Comment 7

[Luke Wagner [:luke]]

Comment on attachment 552444 [details] [diff] [review]
part 2 - move - v1

Review of attachment 552444 [details] [diff] [review]:
-----------------------------------------------------------------

I admire your patch-fu.  I should emulate this.

Comment 8

[Luke Wagner [:luke]]

Comment on attachment 552446 [details] [diff] [review]
part 3 - Debugger - v1

Review of attachment 552446 [details] [diff] [review]:
-----------------------------------------------------------------

So far we have been writing "CallArgs args = ...".  This is two chars more, but, as a nice side effect, "args[0]" reads nicely.  Grepping, there also seems to be "CallArgs call = ..." in a few places... I should fix this; it would be nice to have a canonical name.  r+ with s/ca/args/, or we can continue discussion.

Comment 9

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/users/jblandy_mozilla.com/jsdbg2/rev/eec543e3c644