Closed
Bug 678586
Opened 13 years ago
Closed 13 years ago
Trigger a delayed sync after pairing a new device
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
mozilla10
People
(Reporter: philikon, Assigned: philikon)
Details
(Keywords: verified-aurora, verified-beta, Whiteboard: [verified in services])
Attachments
(1 file, 1 obsolete file)
3.11 KB,
patch
|
asa
:
approval-mozilla-aurora+
asa
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When you add a new device it'd be good to trigger a sync after a little while (having given the new client enough time to sync down and up).
Comment 1•13 years ago
|
||
Possible interaction with Bug 675824, which involves monitoring sync status on the other device to know when to start syncing and showing progress. Might split out the shared work into a "credential exchange progress notification channel" bug...?
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #1) > Possible interaction with Bug 675824, which involves monitoring sync status > on the other device to know when to start syncing and showing progress. Aye. > Might split out the shared work into a "credential exchange progress > notification channel" bug...? Pretty sure this will also need an AbstractSingletonProxyFactoryBean.
Comment 3•13 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #2) > Pretty sure this will also need an AbstractSingletonProxyFactoryBean. …ControllerImpl.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 4•13 years ago
|
||
My crude implementation just schedules another Sync for activeDeviceInterval after a successful exchange. I think that's sufficiently simple yet effective.
Assignee | ||
Comment 5•13 years ago
|
||
Part of this is based on the SendCredentialsController introduced in bug 675823.
Attachment #563591 -
Flags: review?(rnewman)
Comment 6•13 years ago
|
||
Comment on attachment 563591 [details] [diff] [review] v1 Review of attachment 563591 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/syncAddDevice.js @@ +123,5 @@ > delete self._jpakeclient; > self.wizard.pageIndex = DEVICE_CONNECTED_PAGE; > + > + // Schedule a Sync for soonish to fetch the data uploaded by the > + // device we just paired with. I would prefer "to fetch the data uploaded by the device with which we just paired", but then I'm a grammar nazi.
Attachment #563591 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Addresses nit and also adds a test.
Attachment #563591 -
Attachment is obsolete: true
Assignee | ||
Comment 8•13 years ago
|
||
https://hg.mozilla.org/services/services-central/rev/c44a046d72b4
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
Assignee | ||
Comment 9•13 years ago
|
||
STRs for QA: * Pair a new device (A) with an already Sync-connected device (B) * B should trigger a Sync with the "active interval" (by default 5 minutes), regardless of what its regular interval would be (could be 24h or 1h if it was the only device up until then.)
Comment 10•13 years ago
|
||
Build identifier: Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 BuildID: 20111003153830 Connected a new device (A) to a device that already had Sync configured (B); a sync was performed in B after about 1-2 minutes.
Whiteboard: [fixed in services] → [verified in services]
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to Mihaela Velimiroviciu [QA] from comment #10) > Connected a new device (A) to a device that already had Sync configured (B); > a sync was performed in B after about 1-2 minutes. Was B the only device connected to the account? Because B should wait for about 5 minutes before syncing again, so if it syncs earlier than that, something else is going on.
Comment 12•13 years ago
|
||
So far, what I've seen is a sync is fired immediately. That sets the interval to singleDevice 3600. But it actually fires a sync five minutes later. I'm still investigating. I also saw something bad adding an XP client to account. trying to reproduce it.
Assignee | ||
Comment 13•13 years ago
|
||
(In reply to Tracy Walker [:tracy] from comment #12) > So far, what I've seen is a sync is fired immediately. Do you mean bug 688520 or is it actually kicking off a sync immediately after the pairing?
Comment 14•13 years ago
|
||
Ah yes, that's what it is. nevermind. I'm also not able to reproduce the issue on XP I was looking into. I think it may have been miss timing of account deletion and recycling. everything is fine with clean accounts
Assignee | ||
Comment 15•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c44a046d72b4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Assignee | ||
Comment 16•13 years ago
|
||
This bug essentially makes bringing back heartbeats (bug 693758) superfluous. It is a much smaller patch, has less risk, and avoids many unnecessary network requests. I am therefore nominating this instead of bug 693758 to go into Aurora and Beta to avoid poor user experience introduced by increasing the sync intervals (bug 694149).
status-firefox8:
--- → affected
status-firefox9:
--- → affected
tracking-firefox8:
--- → ?
tracking-firefox9:
--- → ?
Assignee | ||
Comment 17•13 years ago
|
||
Comment on attachment 564006 [details] [diff] [review] v2 Nominating this patch for Aurora and Beta. Please see comment 16 for justification.
Attachment #564006 -
Flags: approval-mozilla-beta?
Attachment #564006 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #564006 -
Flags: approval-mozilla-beta?
Attachment #564006 -
Flags: approval-mozilla-beta+
Attachment #564006 -
Flags: approval-mozilla-aurora?
Attachment #564006 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 18•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/32fc4eb5feec
Assignee | ||
Comment 19•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/e31583927cd7
Comment 20•13 years ago
|
||
verified across channels note to self: watch value of services.sync.nextSync to verify this. (don't look for a log)
Status: RESOLVED → VERIFIED
Keywords: verified-aurora,
verified-beta
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•