Closed
Bug 678792
Opened 13 years ago
Closed 13 years ago
Remove --disable-necko-disk-cache
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: matjk7, Assigned: matjk7)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [inbound])
Attachments
(1 file)
18.48 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #552941 -
Flags: review?(khuey)
The patch looks fine if we want to do this ... I'm just not sure if we want to do this.
Comment 3•13 years ago
|
||
Disk cache has a pref, right? (We pref it off in Fennec, IIRC.) Unless building it requires some prerequisites beyond building base Gecko, we should probably just unconditionally build it.
I believe so. Just want confirmation from some Necko folks before we do this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•13 years ago
|
Assignee: nobody → matjk7
Comment 5•13 years ago
|
||
Comment on attachment 552941 [details] [diff] [review] patch Review of attachment 552941 [details] [diff] [review]: ----------------------------------------------------------------- Michal's good with this, so let's do it.
Attachment #552941 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/5046e7177feb
Keywords: checkin-needed
Whiteboard: [inbound]
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5046e7177feb
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Assignee | ||
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 8•13 years ago
|
||
Not much to doc here--I don't see any refs to using this flag on the web. If true, I wouldn't go out of my way to doc that it's been removed. I doubt anyone's been using it.
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to Jason Duell (:jduell) from comment #8) > Not much to doc here--I don't see any refs to using this flag on the web. If > true, I wouldn't go out of my way to doc that it's been removed. I doubt > anyone's been using it. It's mentioned in https://developer.mozilla.org/en/Configuring_Build_Options but that's about it.
Comment 10•13 years ago
|
||
That doc is updated, and the change mentioned in passing on Firefox 8 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•