Closed
Bug 679120
Opened 13 years ago
Closed 13 years ago
Allow negative numbers for integer prefs in mobile about:config
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 9
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
Attachments
(1 file)
1.52 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Open about:config in Fennec 2. Search for "tablet" 3. Try to set "browser.ui.layout.tablet" to -1 Expected results: Pressing the "Down" spinner button will set the pref to -1. Actual results: Once the pref is zero, the down spinner button has no effect. <setting type="integer"> uses min="0" by default. We need to override this in about:config to allow setting prefs with negative numbers.
Attachment #553255 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mbrubeck
Comment 1•13 years ago
|
||
Comment on attachment 553255 [details] [diff] [review] patch Review of attachment 553255 [details] [diff] [review]: ----------------------------------------------------------------- Looks good (assuming it's safe to do so on every integer prefs).
Attachment #553255 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Lucas Rocha from comment #1) > Looks good (assuming it's safe to do so on every integer prefs). about:config only knows whether a pref is string, integer, or boolean; beyond that it can't usefully restrict the values. So it should just allow all values of the correct type, as it does in desktop Firefox. Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9ec7a44e2ab
Status: NEW → ASSIGNED
Whiteboard: [inbound]
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d9ec7a44e2ab
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Comment 4•13 years ago
|
||
Verified Fixed Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110818 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•