Closed
Bug 679364
Opened 13 years ago
Closed 11 years ago
Use either content/devtools/* or content/browser/devtools/* for aliases
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: miker, Assigned: bbenvie)
Details
(Keywords: addon-compat, dev-doc-complete, Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe])
Attachments
(1 file, 2 obsolete files)
25.47 KB,
patch
|
Details | Diff | Splinter Review |
Dolske's comment from bug 582596: ::: browser/devtools/jar.mn @@ +1,5 @@ > browser.jar: > content/browser/NetworkPanel.xhtml (webconsole/NetworkPanel.xhtml) > * content/browser/scratchpad.xul (scratchpad/scratchpad.xul) > * content/browser/scratchpad.js (scratchpad/scratchpad.js) > + content/browser/csshtmltree.xhtml (styleinspector/csshtmltree.xhtml) I'd suggest having a "devtools" namespace here too. Either content/devtools/* or content/browser/devtools/*.
Comment 1•12 years ago
|
||
looks like: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/jar.mn still has some non-devtools-prefixed stuff. Would be good to get these cleaned up. Making this a good first bug.
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe]
I'm looking to get involved with Mozilla. Should I start working on this bug? Also, a little bit more of an explanation would be helpful. Thanks!
Comment 3•12 years ago
|
||
this is still a bug. AL, it would be great if you could help out with this. Miker should be able to get you rolling on it.
Assignee | ||
Comment 4•11 years ago
|
||
I'm going to go ahead and take this.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bbenvie
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #716524 -
Flags: review?(rcampbell)
Comment 6•11 years ago
|
||
(In reply to Brandon Benvie [:bbenvie] from comment #5) > Created attachment 716524 [details] [diff] [review] > Use "content/browser/devtools/*" for aliases Thank you so much for aligning everything in jar.mn. It was driving me crazy!
Comment 7•11 years ago
|
||
Comment on attachment 716524 [details] [diff] [review] Use "content/browser/devtools/*" for aliases Review of attachment 716524 [details] [diff] [review]: ----------------------------------------------------------------- looks good! (and yes. aligning jar.mn was properly righteous)
Attachment #716524 -
Flags: review?(rcampbell) → review+
Updated•11 years ago
|
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe] → [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team]
Assignee | ||
Comment 8•11 years ago
|
||
Alignment is an utmost priority!
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/824b68f13f30
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team]
Assignee | ||
Comment 10•11 years ago
|
||
Fixes the regression where one reference to profiler.xul was missed.
Attachment #716524 -
Attachment is obsolete: true
Attachment #717972 -
Flags: review?(rcampbell)
Comment 11•11 years ago
|
||
backed out in: https://hg.mozilla.org/integration/fx-team/rev/98bb8bc5c30b congrats Brandon! First backout!
Comment 12•11 years ago
|
||
Comment on attachment 717972 [details] [diff] [review] Use "content/browser/devtools/*" for aliases -- updated Need one additional change in ProfilerPanel.jsm, line 58: this.iframe.setAttribute("src", "cleopatra.html?" + uid); (remove devtools/ since we're already at the same relative depth).
Attachment #717972 -
Flags: review?(rcampbell)
Updated•11 years ago
|
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe]
Comment 13•11 years ago
|
||
Any update on that?
Comment 15•11 years ago
|
||
How's this looking? Can we land it?
Assignee | ||
Comment 16•11 years ago
|
||
Finally got back to this. https://tbpl.mozilla.org/?tree=Try&rev=08504b940ae5
Attachment #717972 -
Attachment is obsolete: true
Assignee | ||
Comment 17•11 years ago
|
||
Looks like all the failures are from other intermittent crashers.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe] → [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team]
Comment 18•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4a068034be50
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team]
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 19•11 years ago
|
||
This is not resolved fixed yet :)
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Updated•11 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment 20•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a068034be50
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe]
Target Milestone: --- → Firefox 23
Comment 21•11 years ago
|
||
This has minor add-on compatibility implications, and has been documented already: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23#Firefox_Developer_Tools
Keywords: addon-compat,
dev-doc-complete
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•