Closed
Bug 679483
Opened 13 years ago
Closed 13 years ago
Provide a way to disable this @!#$ rich failure logging that fills my terminal
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: protz, Unassigned)
Details
Attachments
(3 files, 3 obsolete files)
520 bytes,
patch
|
Details | Diff | Splinter Review | |
539 bytes,
patch
|
Details | Diff | Splinter Review | |
3.12 KB,
patch
|
protz
:
review+
|
Details | Diff | Splinter Review |
The title says it all.
Attachment #553570 -
Flags: review?(sagarwal)
Comment 1•13 years ago
|
||
Hmm, I think this should be the other way round -- we shouldn't print rich failures unless we set an env var called (e.g.) MOZMILL_RICH_FAILURES. Then we can update buildbot and set the variable.
Comment 2•13 years ago
|
||
Comment on attachment 553570 [details] [diff] [review] Patch v1 yeah, let's do it the other way round unless you have an objection.
Attachment #553570 -
Flags: review?(sagarwal) → review-
Reporter | ||
Comment 3•13 years ago
|
||
Yeah sure I just need to find the time to figure out how to talk to the buildbots so that they have the right env variable exported, that's all :)
Reporter | ||
Comment 4•13 years ago
|
||
Attachment #553570 -
Attachment is obsolete: true
Attachment #554455 -
Flags: review?(sagarwal)
Reporter | ||
Comment 5•13 years ago
|
||
Sorry, I'd left an extra print in there.
Attachment #554455 -
Attachment is obsolete: true
Attachment #554455 -
Flags: review?(sagarwal)
Attachment #554456 -
Flags: review?(sagarwal)
Comment 6•13 years ago
|
||
Comment on attachment 554456 [details] [diff] [review] Patch v3 Buildbot patches coming up. We'll need to get those in first.
Attachment #554456 -
Flags: review?(sagarwal) → review+
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
Comment 9•13 years ago
|
||
Oh, so you need to define USE_RICH_FAILURES on top as None so that if that code doesn't get run (due to an error perhaps) then python doesn't complain even further about USE_RICH_FAILURES not being defined.
Comment 10•13 years ago
|
||
... as None or False.
Reporter | ||
Comment 11•13 years ago
|
||
Do you want to check this in at the same time you update the build bots? (I don't know if that's the same repo or not).
Attachment #554456 -
Attachment is obsolete: true
Attachment #554513 -
Flags: review+
Comment 12•13 years ago
|
||
It doesn't need to be simultaneous -- the buildbots can go first, since all we're doing is setting a currently unrecognized envvar.
Comment 13•13 years ago
|
||
Mark, gozer, could we get the buildbot patches in sometime?
Comment 14•13 years ago
|
||
buildbot patches (thanks!) have been applied to production, try, and try-unittest. these buildbot instances have been reconfig'd to make the changes live. Now you just need to apply Patch v4 to the tree(s)
Reporter | ||
Comment 15•13 years ago
|
||
http://hg.mozilla.org/comm-central/rev/0056c230da57
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in
before you can comment on or make changes to this bug.
Description
•