Closed
Bug 679689
Opened 13 years ago
Closed 13 years ago
ASSERTION: Empty string? trying to parse HTML image with empty crossorigin attribute
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: neil, Assigned: bzbarsky)
References
()
Details
(Keywords: assertion)
Attachments
(3 files)
I hit this assertion and according to the local variables on the stack the SetAttr in question has a name of "crossorigin" and an empty value.
Reporter | ||
Comment 1•13 years ago
|
||
Reporter | ||
Comment 2•13 years ago
|
||
Looks like they also set it to the empty string in script too...
Comment 3•13 years ago
|
||
Assignee | ||
Comment 4•13 years ago
|
||
nsAttrValue::SetMiscAtomOrString has this code: PRUint32 len = aValue->Length(); // We're allowing eCSSStyleRule attributes to store empty strings as it // can be beneficial to store an empty style attribute as a parsed rule. // Add other types as needed. NS_ASSERTION(len || Type() == eCSSStyleRule, "Empty string?"); Jonas, sounds like we should add enumerated types here, right?
Yeah
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #555477 -
Flags: review?(jonas)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #555477 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•13 years ago
|
Whiteboard: [need review] → [need landing]
Comment 7•13 years ago
|
||
Something in this push caused orange, so backed out of inbound: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=89b87e96dc17 http://hg.mozilla.org/integration/mozilla-inbound/rev/b449db7a038b
Whiteboard: [need landing]
Assignee | ||
Comment 8•13 years ago
|
||
The orange was something else. Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/aa18f8632882
Flags: in-testsuite+
Target Milestone: --- → mozilla9
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/aa18f8632882
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•