Closed
Bug 680037
Opened 13 years ago
Closed 13 years ago
possible use of uninitialized values in nsFontFaceLoader::LoadTimerCallback
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
(Keywords: valgrind)
Attachments
(1 file)
|
1.32 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
In nsFontFaceLoader::LoadTimerCallback, we don't check the GetContentLength and GetNumBytesRead calls for success, which means that we may end up using uninitialized values (in the event one of these calls failed) when testing how far the download has progressed. While this isn't a critical problem - the worst-case result is that we suppress fallback rendering for an extra 50% delay period - we should fix it to ensure more consistent behavior, as well as to avoid Valgrind complaints.
Attachment #554022 -
Flags: review?(jdaggett)
|
||
Updated•13 years ago
|
Attachment #554022 -
Flags: review?(jdaggett) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/d051bc49c304
Whiteboard: [inbound]
|
||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d051bc49c304
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•