680198 - Add link to easily mark attachments obsolete

Status: RESOLVED WONTFIX

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Josh Matthews [:jdm]]

It's a pain to go to an attachment, click "edit details", click the obsolete checkmark, then submit the changes. It would be a lot nicer to have an inline button or link in the attachments box for each entry that allowed marking it as obsolete.

Comment 1

[David Lawrence [:dkl]]

Lets move this to upstream as it is not really a BMO specific issue and see if anyone has any ideas on how best to implement this type of shortcut.

Comment 2

[Frédéric Buclin]

I disagree. You generally don't want to mark an attachment as obsolete without at least looking at it, which you do from the Details page where the obsolete checkbox is.

Comment 3

[Josh Matthews [:jdm]]

I typically need to mark old versions of patches obsolete when I upload new ones. I hate hate hate the number of clicks involved in this. However, I don't see it as being something that is desired by many bugzilla users, hence my placement in the tweaks addon.

Comment 4

[Josh Matthews [:jdm]]

Note that I upload attachments through a script that automatically marks identially-named existing attachments obsolete. This fails on occasion for reasons that are unimportant, hence why I don't just mark attachments obsolete via the regular upload mechanism.

Comment 5

[Reed Loden [:reed]]

(In reply to Josh Matthews [:jdm] from comment #4)
> Note that I upload attachments through a script that automatically marks
> identially-named existing attachments obsolete. This fails on occasion for
> reasons that are unimportant, hence why I don't just mark attachments
> obsolete via the regular upload mechanism.

Honestly, sounds like your script should be fixed then. Most people can easily obsolete other attachments via the normal upload mechanism, so I don't really see the value of adding yet more useless UI for doing this.

Comment 6

[David Lawrence [:dkl]]

I am not sure how this would work in Bugzilla Tweaks either as currently the WebService API does not allow for editing of current attachment attributes such as obsolete. Also, created a custom URL and using attachment.cgi will not work as looks for a valid token provided by the attachment details form before committing any changes. Have a custom link from the show_bug.cgi page next to each attachment in the table called "Obsolete" or similar would need to somehow contain a valid token which you can't do on the client side.

So to make this work as a feature of Bugzilla itself, the workings of attachment.cgi would also need to change.

dkl

Comment 7

[Frédéric Buclin]

Wontfix per the discussion above (and as already said, you can already mark older attachments as obsolete when uploading new ones).