680275 - test_delay_load.html incorrectly appends a video to a new window before it has begun loading

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Josh Matthews [:jdm]]

This only passes in Firefox because we happen to return to the event loop and run the event that starts the load while opening the new window. In Fennec, this doesn't occur, and we don't start the load until after the video has been appended to the new window. This causes the load to fail, because it's a relative URL from about:blank.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Ensure that the video load begins before adding the video to a new document.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Ensure that the video load begins before adding the video to a new document.

Comment 3

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/cd982d1f49d6

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/cd982d1f49d6

Comment 5

[cajbir (:cajbir)]

The landing of this seems to have caused an issue when I run the content/media mochitests. The test_delay_load.html test now leaves a popup window open at the end of the tests. Reverting the patch in this bug fixes it for me.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The problem seems to be that onloadstart is never called for the element that gets put in the other window. At least the event handler never fires.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, so what happens is that v.onloadstart does window.open, which seems to spin the event loop so that the load event fires in there. Which means loaded() actually runs before we add the window to 'testWindows', so the window isn't closed.

For the test to work we really need to avoid our events firing during window.open. I'll try doing the window.open early, outside the event handler.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix test

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10f58db28c81

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/10f58db28c81