680376 - Source Editor does not give visual indication of read-only mode

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Cedric Vivier [:cedricv]]

When switching SourceEditor.readOnly to true, key presses are not handled anymore (good) but the editor does not provide any visual indication.

It should probably change the background color to gray (or -moz-dialog) or something, so that the user knows that it is read-only and what to expect.

Comment 1

[Mihai Sucan [:msucan]]

This is probably not something for minotaur. (feel free to disagree!)

I am not sure if it's up to the editor to make any visual indication of the readonly mode.

We need to provide a visual indication of the editor being in read only mode, but consider the scenario of using the Source Editor inside the debugger or view source, where you set readonly=true but you don't want to have a gray background. So, really, we need a way to easily customize the styling of the editor iframe - so Style Editor can change the background to gray (for example) when the user switches to a readonly stylesheet.

Comment 2

[Mihai Sucan [:msucan]]

This is now fixed by bug 702331.