680534 - Clean up IDL Directory Rules in rules.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Attachment: Remove double colon and redundancy of $(IDL_DIR), v1

Currently, the $(IDL_DIR) target in rules.mk has the following issues:

1) It is defined as a double colon rule, so it gets executed every single time
2) It is defined twice

The attached patch converts it to a regular rule and removes an inner definition. I believe the remaining definition is always in an outer scope and is thus always defined to the bits that need it. Although, the conditional statements in this part of rules.mk are nested pretty deep, so I could be wrong.

I also believe everything writing into $(IDL_DIR) has $(IDL_DIR) as a prerequisite, so removing the double colon should be safe.

I've done the following to verify the change:

* Built w/ make from empty objdir
* Rebuilt a subcomponent w/ make that used to always nsinstall $(IDL_DIR) and verified it didn't do this any more

I'm not sure how much this improves build times by, but it should be greater than 0.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Remove double colon and redundancy of $(IDL_DIR), v2

Added missing identical change to JS's rules.mk and added bug number to summary.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 554520 [details] [diff] [review]
Remove double colon and redundancy of $(IDL_DIR), v2

Can we drop the comment above the $(IDL_DIR) rule we're keeping.  I don't think that's been accurate in the better part of a decade ...

Comment 3

[Gregory Szorc [:gps]]

Attachment: Remove double colon and redundancy of $(IDL_DIR), v3

This is the same patch that was r+ by khuey except the outdated comment has been removed, per comment from khuey.

Comment 4

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ee70d6bb2c8

Comment 5

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/1ee70d6bb2c8