680897 - There should be a colon after "You have chosen to open" in download window

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Tanner Filip [:tanner]]

Attachment: Patch

Very, very tiny thing that annoys me, there should probably be a colon to match the rest of the info lines, and grammatically (at least from what I'm told) would be best if it were.

Comment 1

[Shawn Wilsher :sdwilsh]

Hmm, I think we need to change the entity name here too (which makes the patch a bit more complicated).

Comment 2

[Shawn Wilsher :sdwilsh]

gavin - do we need to change the entity name in this case?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Yes - better to err on the side of changing rather than not changing, and there's only use use of this string in this case.

Comment 4

[Chris Lee (:cleer)]

Attachment: Changed entity name

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 630019 [details] [diff] [review]
Changed entity name

You need to update the code that uses &intro.label;

Comment 6

[Chris Lee (:cleer)]

Attachment: Patch

Updated entity name

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 630029 [details] [diff] [review]
Patch

I think you forgot to make the string change :)

Comment 8

[Chris Lee (:cleer)]

Attachment: Patch v4

d'oh. Good now?

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 640438 [details] [diff] [review]
Patch v4

Yes, thanks.

Comment 10

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2888cfe516c

Try push: https://tbpl.mozilla.org/?tree=Try&rev=541189b99439

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e2888cfe516c