681078 - [traceback] AttributeError: 'HTTPError' object has no attribute 'reason' if manifest URL has a typo

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/en-US/developers/addon/submit/2
2. Enter the manifest URL with a typo or copy+paste https://people.mozilla.com/~jbalogh/ztype.webap
3. Click 'Alright then!'


Traceback (most recent call last):

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 94, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 86, in wrapper
   return f(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 28, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 49, in wrapper
   return f(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 598, in upload_webapp
   tasks.fetch_manifest(form.cleaned_data['manifest'], upload.pk)

 File "/data/amo_python/www/preview/zamboni/vendor/lib/python/celery/task/base.py", line 241, in __call__
   return self.run(*args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/vendor/lib/python/celery/app/__init__.py", line 141, in run
   return fun(*args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/vendor/src/nuggets/celeryutils.py", line 35, in wrapped
   return fun(*args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 330, in fetch_manifest
   content = _fetch_manifest(url)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/tasks.py", line 299, in _fetch_manifest
   if isinstance(e.reason, socket.timeout):

AttributeError: 'HTTPError' object has no attribute 'reason'

Comment 1

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/e55725b

Comment 2

[krupa raj[:krupa]]

verified fixed.