681519 - ID for change.synckey.acceptButton has not been changed

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Alexander L. Slovesnik]

From Bug 656492:

> -change.synckey.acceptButton = Change Sync Key
> +change.synckey.acceptButton = Change Recovery Key

ID for change.synckey.acceptButton in syncGenericChange.properties has not been changed. It should be changed for l10n purposes.
It's changed in change.recovery.acceptButton in syncGenericChange.js so I suspect that now UI is broken.

Comment 1

[Philipp von Weitershausen [:philikon]]

Even worse, the code that uses the string was updated, but to a nonsensical string ID. Should've spotted this in review, my bad.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

There was one more string ID that wasn't correct. Also removed an unused string.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 555269 [details] [diff] [review]
v1

Review of attachment 555269 [details] [diff] [review]:
-----------------------------------------------------------------

m-i! m-i!

Comment 4

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/198c7de0699d

Comment 5

[Philipp von Weitershausen [:philikon]]

STRs for QA:

Apart from the fact that the string ID wasn't renamed, there were also two bugs concerning the the button and the explanatory text in the "My Sync Key" dialog. Those labels weren't updated and an exception occurred in the Error Console. These were fixed.

Comment 6

[Tracy Walker [:tracy]]

verified on m-c