681870 - IndexedDB: Prompts can crash when multiple windows are open

Status: VERIFIED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sicking figured out our phantom prompt crash today, and will attach a patch shortly.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/458f82155cad

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 555659 [details] [diff] [review]
Patch to fix

This fixes a pretty nasty bug in our indexedDB code. The result is that we end up crashing in case the user has multiple windows open when a indexedDB database is created.

The risk is very low as the fix is very simple. It also only affects indexedDB code, so worst case it shouldn't affect many sites as indexedDB isn't widely used yet.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/458f82155cad

Comment 5

[Christopher Blizzard (:blizzard)]

Comment on attachment 555659 [details] [diff] [review]
Patch to fix

Approved for Beta (Update 7) and Aurora (Update 8).  Please check it in as soon as possible.

Also clearing the 1.9.2.21 flag as we didn't include this before Firefox 4.

Comment 6

[LegNeato]

http://hg.mozilla.org/releases/mozilla-aurora/rev/977d2522dd8c
http://hg.mozilla.org/releases/mozilla-beta/rev/20e2bf4545f0

Comment 7

[Ioana (away)]

Can anyone please help me with some STR/guidelines I can use to verify this fix?

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Ioana Budnar [QA] from comment #7)
> Can anyone please help me with some STR/guidelines I can use to verify this
> fix?

The only way we were able to reproduce this was to open two browser windows (not tabs, but windows), and point one to a site that uses IndexedDB but had never been granted permission before. Initiating IndexedDB usage then would trigger a prompt, sometimes in both windows, and clicking Allow in both prompts would cause a crash. IndexedDB should only ever produce a prompt in one window.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to ben turner [:bent] from comment #8)
> ... and point one to a site that uses IndexedDB

One such site is http://davidflanagan.com/demos/zipcodes.html

Comment 10

[Ioana (away)]

Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0) Gecko/20100101 Firefox/7.0
Build ID: 20110902161802

STR:
1. Open 2 Fx windows.
2. Load http://davidflanagan.com/demos/zipcodes.html in both windows.
3. Input a zip code in one of the windows (or both).
4. Click on the Allow button in the prompt.
The prompt with the Allow button only appears in one of the windows. Firefox works fine after clicking the Allow button.

Comment 11

[u279076]

QA tracking; still needs verification on Firefox 8.

Comment 12

[Ioana (away)]

Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a2) Gecko/20110911 Firefox/8.0a2 
Build ID: 20110911042006
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:9.0a1) Gecko/20110911 Firefox/9.0a1
Build ID: 20110911030845

STR:
1. Open 2 Fx windows.
2. Load http://davidflanagan.com/demos/zipcodes.html in both windows.
3. Input a zip code in one of the windows (or both).
4. Click on the Allow button in the prompt.
The prompt with the Allow button only appears in one of the windows. Firefox works fine after clicking the Allow button.