Closed
Bug 681893
Opened 13 years ago
Closed 13 years ago
Fixups for MSVC > 8 after bug 678161
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: fixed-in-bs)
Attachments
(1 file)
One issue is in bug 678161 comment 11: +ifeq ($(_MSC_VER),1500) +JSSHELL_BINS += $(DIST)/bin/msvcr100.dll +endif 1500 should be 1600. Another issue is that we don't remove the CRT dlls for MSVC versions we don't build against.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #555677 -
Flags: review?(khuey)
Attachment #555677 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/projects/build-system/rev/c37f23b36e54
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/c37f23b36e54
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•13 years ago
|
Attachment #555677 -
Attachment description: Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive → Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive
[Checked in: Comment 3]
|
|
||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Flags: in-testsuite-
|
|
||
Comment 4•13 years ago
|
||
Isn't @BINPATH@ unneeded/unwanted in removed-files.in?
|
|
Assignee | |
Comment 5•13 years ago
|
||
Ah yes, that's true. Please file a followup bug.
|
|
||
Comment 6•13 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5) > Ah yes, that's true. Please file a followup bug. I filed bug 696422.
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•