Closed
Bug 682088
Opened 13 years ago
Closed 13 years ago
Value "browser.display.focus_background_color" should allow for transparent or alternate CSS value
Categories
(Core :: Layout, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: tamma00, Assigned: bzbarsky)
Details
Attachments
(1 file)
1.50 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Since bug [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569]641569[/url] turned out invalid - submitting this instead. Originally the problem was: [quote]Setting "browser.display.use_focus_colors" value to "true" causes odd overlay with specific image viewer on many webpages.[/quote] As per [url=https://bugzilla.mozilla.org/show_bug.cgi?id=641569#c9]Comment 9[/url] on the first bug it would seem that the real issue is that "browser.display.use_focus_colors" causes anything matching ":focus" and anything matching ":focus>font" to have the default focus foreground and background color unless the page styles them otherwise.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #555934 -
Flags: review?(dbaron)
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: P5 → P3
Whiteboard: [need review]
Comment on attachment 555934 [details] [diff] [review] This should do it I think you should make the function take const nsString&, and make the callers use Preferences::GetString instead of GetCString. r=dbaron with that, but note that this conflicts with bug 629882
Attachment #555934 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•13 years ago
|
||
> I think you should make the function take const nsString&, and make the callers use > Preferences::GetString instead of GetCString. Done. > but note that this conflicts with bug 629882 I'll give ms2ger a heads-up.
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/073b4ef6933f
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla10
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/073b4ef6933f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•