682182 - Block updates to de-supported Windows versions at switch to Visual C++ 2010

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bug 668436 has information on versions to block, this is just for the config file changes. Would need to figure out if 64bit XP needs blocking too, QA may be able to help.

Best case is deploying the AUS config on the day we swap to the new compiler, so that we don't brick anyone's Nightly. Once bug 668436 lands, we'll be able to tell how many users are affected.

Needs the AUS code changes in bug 666735 to target minor updates for end users, and nightlies.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [cvs] wip config change

This is the sort of thing we'd want to block updates for Win 2000, Win XP RTM and SP1, assuming we make the switch while Firefox 11 is in nightly. Untested at this point.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Another option:
Coordinate this with the LTS release, so that we can switch users on SP1 or lower to the LTS release, giving them 12 more months of security fixes "for free" until they can install SP2 or later. This would mean that, if the LTS release is Firefox 12, that we should start doing this for Firefox 12 too.

Comment 3

[(no longer active)]

This might not be necessary by switching to VS2010.  See bug 563318 comment 24.

Comment 4

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

removing sec-review-needed, we might care about the text displayed but not this directly

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Are we planning to switch to VS 2010 early in the 13.0 cycle then ?

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Nick Thomas [:nthomas] from comment #6)
> Are we planning to switch to VS 2010 early in the 13.0 cycle then ?

Yes.

Comment 8

[Ed Morley [:emorley]]

Attachment: nthomas's patch updated for 13.0a1+

Updated version number to reflect current trunk version. Don't believe nthomas has tested this yet.

(MSVC2010 switch landed today, so if we are concerned about Win2k/pre WinXP sp2 Nightly users receiving updates that won't function - this needs to be landed before the next m-c Nightly is generated.)

Comment 9

[(no longer active)]

(In reply to Ed Morley [:edmorley] from comment #8)
> Created attachment 593185 [details] [diff] [review]
> nthomas's patch updated for 13.0a1+
> 
> Updated version number to reflect current trunk version. Don't believe
> nthomas has tested this yet.
> 
> (MSVC2010 switch landed today, so if we are concerned about Win2k/pre WinXP
> sp2 Nightly users receiving updates that won't function - this needs to be
> landed before the next m-c Nightly is generated.)

It bounced unfortunately.

Note that without this, the update experience would be that when you restart your browser, you will get a dialog saying that function foo could not be loaded from dll bar, at which point you're done being able to use Firefox unless if you redownload a version which works on your OS.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

We'll definitely get this landed. Can anyone confirm the OS's we want to block are correctly included in attachment 593185 [details] [diff] [review] ?

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Nick Thomas [:nthomas] from comment #10)
> We'll definitely get this landed. Can anyone confirm the OS's we want to
> block are correctly included in attachment 593185 [details] [diff] [review] ?

Landed when 2010 sticks, that is. I don't have those OS to test directly, but I can deploy the patch to a testing update server and munge URLs.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

ashughes, with your Win2K VM could you try this:

1, setup and enable an mpt-vpn connection (need to reach aus2-staging.m.o on an internal IP)
2, install http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/01/2012-01-30-03-11-42-mozilla-central/firefox-12.0a1.en-US.win32.installer.exe
3, set app.update.url.override to
http://aus2-staging.mozilla.org/update/3/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/test/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
4, check for updates

None should be found. (The testing setup is a production aus + attachment 593185 [details] [diff] [review]; the current update for en-US locale duplicated to 'test', with the version bumped from 12.0a1 to 13.0a1 so the patch kicks in).

If anyone lurking on this bug has XP RTM or XP SP1 available and can try that too that'd be great.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Against that test server the following do not return an update with the patch (but do without):
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 5.0.4.0 (x86)/default/default/update.xml
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 5.1.0.0 (x86)/default/default/update.xml
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 5.1.1.0 (x86)/default/default/update.xml

and these still do:
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 5.1.2.0 (x86)/default/default/update.xml
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 5.1.3.0 (x86)/default/default/update.xml
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 6.0.2.0 (x86)/default/default/update.xml
http://aus2-staging.mozilla.org/update/3/Firefox/12.0a1/20120130031142/WINNT_x86-msvc/test/nightly/Windows_NT 6.1.1.0 (x64)/default/default/update.xml

Comment 14

[u279076]

(In reply to Nick Thomas [:nthomas] from comment #12)
> ashughes, with your Win2K VM could you try this:
> 
> 1, setup and enable an mpt-vpn connection (need to reach aus2-staging.m.o on
> an internal IP)

Sadly, I don't think I have MPT access. Anyone in QA with MPT access should be able to test this for you. The VM is available to everyone.

Comment 15

[u279076]

Nevermind, I just got access. I will see if I can test this now.

Comment 16

[u279076]

Tested as per comment 13 on Windows 2000, no update found.

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Anthony, that's great! Could you reset app.update.url.override and verify an update is found ? Should be the 2012-01-31 nightly, which will still run.

I've got an XP RTM VM setup now and will test that and SP1.

Comment 18

[u279076]

(In reply to Nick Thomas [:nthomas] from comment #17)
> Anthony, that's great! Could you reset app.update.url.override and verify an
> update is found ? Should be the 2012-01-31 nightly, which will still run.
> 
> I've got an XP RTM VM setup now and will test that and SP1.

Confirmed. Resetting the pref downloads 2012-01-31.

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Great. Looks like XP is working too in a quick check. I'll verify that and get the AUS patch deployed today.

Comment 20

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 593185 [details] [diff] [review]
nthomas's patch updated for 13.0a1+

Verified working on XP RTM and SP1, and no effect on XP SP3.

Checking in config-dist.php;
/cvsroot/mozilla/webtools/aus/xml/inc/config-dist.php,v  <--  config-dist.php
new revision: 1.187; previous revision: 1.186
done

$ cvs tag AUS2_PRODUCTION config-dist.php
W config-dist.php : AUS2_PRODUCTION already exists on version 1.186 : NOT MOVING tag to version 1.187
$ cvs tag -F AUS2_PRODUCTION config-dist.php
T config-dist.php

Comment 21

[Nick Thomas [:nthomas] (UTC+12)]

Verified working in production.

Comment 22

[u279076]

QA tested this a while back but I neglected to update the bug. Marking verified.

Comment 23

[Justin Wood (:Callek)]

Just for posterity, I realized I never applied this to SeaMonkey's aus2. And I just manually applied that now for 2.10a1+