682239 - Tests all HTMLFormElement attributes reflection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 555989 [details] [diff] [review]
Patch v1

r=me with this addressed

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
 function reflectLimitedEnumerated(aParameters)
 {
   var element = aParameters.element;
-  var attr = aParameters.attribute;
+  var contentAttr = typeof aParameters.attribute === "string"
+                      ? aParameters.attribute : aParameters.attribute.content;
+  var idlAttr = typeof aParameters.attribute === "string"
+                  ? aParameters.attribute : aParameters.attribute.idl;
   var defaultValue = aParameters.defaultValue !== undefined
     ? aParameters.defaultValue : "";
   var unsupportedValues = aParameters.unsupportedValues !== undefined
     ? aParameters.unsupportedValues : [];

Please make the indentation match for these four; either way is fine.

--- a/content/html/content/test/test_bug585508.html
+++ b/content/html/content/test/test_bug585508.html
 var button = document.createElement('button');
 checkAttribute(button, 'formenctype', 'formEnctype', enctypeTestData);
 checkAttribute(button, 'formmethod', 'formMethod', methodTestData);

And I seem to remember you were planning to fix bug 673553?

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/3faac1e63f57