Closed
Bug 682327
Opened 13 years ago
Closed 13 years ago
ASSERTION: Failed to make GL context current!: 'succeeded' GLContextProviderEGL.cpp, line 795
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
1.35 KB,
patch
|
Details | Diff | Splinter Review |
Ok, problem seems to be caused by http://hg.mozilla.org/mozilla-central/rev/6e7449c449ba#l2.33 we should not check mSurface on Qt port.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Comment 2•13 years ago
|
||
Comment on attachment 556066 [details] [diff] [review] Move surface check before MakeCurrent conditions Review of attachment 556066 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, with a small fix needed. ::: gfx/thebes/GLContextProviderEGL.cpp @@ +785,4 @@ > #ifndef MOZ_WIDGET_QT > + if (!mSurface) { > + EGLConfig config = CreateConfig(); > + mSurface = CreateSurfaceForWindow(NULL, config); We still need a call to fMakeCurrent when we create a new surface. So add the line: aForce = PR_TRUE;
Attachment #556066 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #556066 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c62371f0112a
Keywords: checkin-needed
Target Milestone: --- → mozilla9
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c62371f0112a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•