Closed
Bug 683159
Opened 13 years ago
Closed 11 years ago
stylesheet not found assertions at shutdown.
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: khuey, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.13 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
The assertion at http://hg.mozilla.org/mozilla-central/file/31b79d4e90f4/content/base/src/nsDocument.cpp#l3556 is firing on shutdown on Mac mochitest-other runs on tinderbox. I added some instrumentation and made this assert a hard abort and found the following: That assertion fires with the following stack: ###!!! ABORT: stylesheet not found: file /builds/slave/try-osx64-dbg/build/content/base/src/nsDocument.cpp, line 3573 nsDocument::RemoveStyleSheet [content/base/src/nsDocument.cpp:3574] nsStyleLinkElement::DoUpdateStyleSheet [content/base/src/nsStyleLinkElement.cpp:226] nsStyleLinkElement::UpdateStyleSheetInternal [content/base/src/nsStyleLinkElement.cpp:207] nsXMLStylesheetPI::UnbindFromTree [content/xml/content/src/nsXMLStylesheetPI.cpp:141] nsDocument::cycleCollection::Unlink [content/base/src/nsDocument.cpp:1921] nsXULDocument::cycleCollection::Unlink [content/xul/document/src/nsXULDocument.cpp:391] nsCycleCollector::CollectWhite [xpcom/base/nsCycleCollector.cpp:2009] nsCycleCollector::FinishCollection [xpcom/base/nsCycleCollector.cpp:2838] nsCycleCollectorRunner::Collect [xpcom/base/nsCycleCollector.cpp:3526] nsCycleCollector_collect [xpcom/base/nsCycleCollector.cpp:3592] nsJSContext::CycleCollectNow [dom/base/nsJSEnvironment.cpp:3193] The document is chrome://global/content/customizeToolbar.xul and the sheet in question is chrome://global/skin/customizeToolbar.css. That sheet was previously removed in a call to nsDocument::RemoveStyleSheet with the following stack: nsDocument::RemoveStyleSheet [content/base/src/nsDocument.cpp:3560] nsDocument::UpdateStyleSheets [content/base/src/nsDocument.cpp:3616] nsChromeRegistry::RefreshWindow [chrome/src/nsChromeRegistry.cpp:531] nsChromeRegistry::RefreshWindow [chrome/src/nsChromeRegistry.cpp:439] nsChromeRegistry::RefreshSkins [chrome/src/nsChromeRegistry.cpp:403] nsChromeRegistryChrome::Observe [chrome/src/nsChromeRegistryChrome.cpp:384] nsPrefBranch::NotifyObserver [modules/libpref/src/nsPrefBranch.cpp:674] pref_DoCallback [modules/libpref/src/prefapi.cpp:944] pref_HashPref [modules/libpref/src/prefapi.cpp:801] PREF_SetCharPref [modules/libpref/src/prefapi.cpp:283] nsPrefBranch::SetCharPref [modules/libpref/src/nsPrefBranch.cpp:196] mozilla::Preferences::SetCharPref [Preferences.h:77] NS_InvokeByIndex_P [xpcom/reflect/xptcall/src/md/unix/xptcinvoke_x86_64_unix.cpp:195] This happens during browser_bug592338.js.
Reporter | ||
Comment 1•13 years ago
|
||
Actually, this fires on other platforms too, just with a useless stack (at least on Windows).
Reporter | ||
Updated•13 years ago
|
Summary: stylesheet not found assertions at shutdown on Mac. → stylesheet not found assertions at shutdown.
Version: 8 Branch → Trunk
Assignee | ||
Comment 2•13 years ago
|
||
Yeah, the RefreshSkins thing is sorta broken....
Comment 3•11 years ago
|
||
This is causing oranges now :/
https://hg.mozilla.org/integration/mozilla-inbound/rev/67060725ec8d to reduce the spatter across the following tests. I still need to clean up the later SimpleTest.expectAssertions calls.
Whiteboard: [leave open]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67060725ec8d https://hg.mozilla.org/mozilla-central/rev/57fc2a37629f
Followup test cleanup in: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba681ef61a3a
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ba681ef61a3a
Comment 9•11 years ago
|
||
With bug 850090 backed out, comment 6 should be safe to backout now (and actually was already partially done in another push as a bustage fix). https://tbpl.mozilla.org/?tree=Try&rev=e0d9d310bcd0
Assignee | ||
Comment 10•11 years ago
|
||
This got fixed in bug 850090. We should be able to remove the expected assertions annotation now.
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #756973 -
Flags: review?(Ms2ger)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Comment 12•11 years ago
|
||
Comment on attachment 756973 [details] [diff] [review] Remove now-irrelevant assertion annotation. Review of attachment 756973 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #756973 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/167144438549
Whiteboard: [leave open]
Target Milestone: --- → mozilla24
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/167144438549
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•