683786 - checkbox missing in dropdowns in web pages when tablet ui is turned on

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. turn on tablet ui
2. go to http://people.mozilla.com/~nhirata/html_tp/formsninput.html
3. select the dropdown

Expected: to see a checkmark next to the current selection
Actual: nothing

Mozilla/5.0 (Android; Linux armv7I; rv9.0a1) Gecko/20110831 Firefox/9.0a1 Fennec/9.0a1
Device: Toshiba Thrive
OS Android 3.1

Comment 1

[Matt Brubeck (:mbrubeck)]

Sriram, can you take a look at this please?

Comment 2

[Sriram Ramasubramanian [:sriram]]

Here is my analysis:

1. There is no form.css inside /themes/core/honeycomb/ - which makes it to take the default css.
2. The default css uses check-30.png for the check mark. This is not available inside honeycomb folder, and there is no define in jar.mn - this makes it not to display a checkmark.

I guess, we would have to wait for the form controls to be flushed out by Ian Barlow for honeycomb theme, to come up with forms.css.

I would be happy to work on forms.css for honeycomb :)

Comment 3

[Matt Brubeck (:mbrubeck)]

For the moment, just to stay in a more or less usable state, let's either add back honeycomb/images/check-30.png, or add a honeycomb/forms.css that uses one of the current honeycomb checkmark images.  Whichever works best.  (Either way, we can change it again once we get real specs from Ian.)

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Temporary patch

This is a temporary patch until the honeycomb theme is flushed out completely.
I changed the jar.mn to make the honeycomb theme refer to froyo's check mark for the select's pop-up box.

Comment 5

[Matt Brubeck (:mbrubeck)]

hg.mozilla.org/integration/mozilla-inbound/rev/4f3eb6d6dcf5

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/4f3eb6d6dcf5

Comment 7

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android, Linux armv7l; rv:9.0a1) Gecko/20110906 Firefox/9.0a1 Fennec/9.0a1