Closed
Bug 684011
Opened 13 years ago
Closed 12 years ago
Page-mod documentation should link to worker's documentation earlier.
Categories
(Add-on SDK Graveyard :: Documentation, defect, P3)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Assigned: canuckistani)
Details
Attachments
(1 file, 1 obsolete file)
1.53 KB,
patch
|
canuckistani
:
review+
|
Details | Diff | Splinter Review |
Currently, the first link to worker's documentation is way down in "Mapping workers to tabs", which is below the halfway point in the page. But 'worker' is first mentioned up near the top in "Communicating With Content Scripts". I would move the link for worker's docs up to that first mention of 'worker', personally. If the big "working with content scripts" rewrite will change the page-mod docs, too, feel free to wontfix this.
Assignee | ||
Comment 1•13 years ago
|
||
I just checked, the patch ( or my current modifications to said patch ) for bug 679479 do not edit page-mod.md. This should definitely be a separate bug.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → jgriffiths
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Patch to move the link to the worker docs to the earliest sensible instance of the word worker. We could move it one line earlier but stylistically I think this placing of the link makes it more find-able.
Updated•13 years ago
|
OS: Windows 7 → All
Priority: -- → P3
Hardware: x86_64 → All
Reporter | ||
Updated•12 years ago
|
Attachment #557640 -
Flags: review?(wbamberg)
Comment 3•12 years ago
|
||
Comment on attachment 557640 [details]
Move the link to the worker docs
This patch doesn't apply cleanly any more. I've regenerated one that does, and attached it. Shall I just push it? It seems silly to ask for reveiw again, for such a trivial change...
Attachment #557640 -
Flags: review?(wbamberg) → review-
Comment 4•12 years ago
|
||
Attachment #557640 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 650560 [details] [diff] [review] another patch Review of attachment 650560 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #650560 -
Flags: review+
Comment 6•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/98940794970e265960c71657f3d24d87c627a2e7 Fix bug 684011 - Page-mod documentation should link to worker's documentation earlier.; r=@canuckistani
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•