Closed
Bug 684135
Opened 13 years ago
Closed 13 years ago
Shutdown crash reporting exception [@ nsTHashtable<nsBaseHashtableET<nsUint64HashKey, nsGlobalWindow*> >::GetEntry ]
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: crash)
Crash Data
Attachments
(2 files)
|
5.19 KB,
text/plain
|
Details | |
|
939 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
While shutting down, I crashed today trying to report an exception (see the attached stack). What appears to have happened is that during shutdown some sort of "race" in an extension I have caused an exception to be thrown from an nsITimer callback. Reporting the exception in XPConnect tries to get the inner window from the inner window ID. However, we're already far enough into shutdown that the call to nsGlobalWindow::GetInnerWindowWithId crashes because we've already nulled out nsGlobalWindow::sWindowsById.
|
Assignee | |
Comment 1•13 years ago
|
||
I can see a few ways of fixing this: add the null check here or in nsScriptError or check that we're in shutdown somehow in nsScriptError. I don't have a strong opinion for any of the options though. I haven't been able to reproduce the crash since the first time, sadly.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 557745 [details] [diff] [review] patch v1 r=me
Attachment #557745 -
Flags: review?(bzbarsky) → review+
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d06e88a99f39
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•13 years ago
|
Severity: normal → critical
Crash Signature: [@ nsTHashtable<nsBaseHashtableET<nsUint64HashKey, nsGlobalWindow*> >::GetEntry ]
Keywords: crash
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•