Closed
Bug 684190
Opened 13 years ago
Closed 13 years ago
"about:newaddon" in urlbar instantly closes tab/browser.
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla10
People
(Reporter: pjdkrunkt, Assigned: felix)
References
Details
(Whiteboard: [testday-20111118])
Attachments
(1 file)
1.49 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.20) Gecko/20110803 Firefox/3.6.20 Build ID: 20110803131630 Steps to reproduce: Type "about:newaddon" in urlbar attempting to show the Install Add-on tab dialog in an attempt to work on the theme style. Actual results: Tab instantly closes... if only one tab, browser instantly closes. No crash report is generated. If only one tab and browser closes, must delete places.sqlite and sessionstore files in profile to re-open browser. Expected results: Display a placeholder "about:newaddon" page like blank about:sessionrestore page.
Comment 1•13 years ago
|
||
Confirmed on Nightly9.0a1 and Aurora8.0a2. http://hg.mozilla.org/mozilla-central/rev/d772dfb96ba1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110901 Firefox/9.0a1 ID:20110901030807 and http://hg.mozilla.org/releases/mozilla-aurora/rev/03b0d42603f8 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/8.0a2 ID:20110901042012
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•13 years ago
|
||
Confirmed on Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110901 Firefox/9.0a1
OS: Windows XP → All
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → ffung
Assignee | ||
Comment 3•13 years ago
|
||
Summary of Changes: - If there is no id parameter, show about:blank instead of closing window.
Attachment #563646 -
Flags: review?(bzbarsky)
Updated•13 years ago
|
Attachment #563646 -
Flags: review?(bzbarsky) → review?(dtownsend)
Updated•13 years ago
|
Component: General → Add-ons Manager
Product: Firefox → Toolkit
QA Contact: general → add-ons.manager
Updated•13 years ago
|
Attachment #563646 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/05a4fd114908
Flags: in-testsuite-
Target Milestone: --- → mozilla10
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/05a4fd114908
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
Maybe it's not important, but there's another window.close() a few lines down for if there is an id which isn't valid, so I guess typing "about:newaddon?blah" would still close the tab/window.
I have verified this on latest Nightly: Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 and typing "about:newaddon" doesn't close the tab anymore instead it shows a blank tab even though I have new add-ons installed. This is intended? Thanks.
Assignee | ||
Comment 8•13 years ago
|
||
Yes this is intended.
Assignee | ||
Comment 9•13 years ago
|
||
On second thought. This should be improved some more. The expected behavior should be: If you only have one tab and you direct it to about:newaddon, it should point you to about:blank. If you have multiple tabs and you direct it to about:newaddon, it should close the tab.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•13 years ago
|
||
(In reply to Felix Fung (:felix) from comment #9) > On second thought. This should be improved some more. The expected behavior > should be: > > If you only have one tab and you direct it to about:newaddon, it should > point you to about:blank. > If you have multiple tabs and you direct it to about:newaddon, it should > close the tab. I don't think this is really worth the effort, and I certainly don't want the code in there to be reliant on tabbrowser APIs
Comment 11•13 years ago
|
||
Also, this patch landed, followup patches go in new bugs.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Comment 13•13 years ago
|
||
Verified on GNU/Linux (comment 7, comment 8) by chaos, vladmaniac and me with at least these builds: Aurora: Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111117 Firefox/10.0a2 Nightly: Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111117 Firefox/11.0a1 Nightly: Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111117 Firefox/11.0a1
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20111118]
Comment 14•13 years ago
|
||
What about a manual test? Do we need one here, because we can't cover it by automation? I would tend to say so.
Flags: in-litmus?
Comment 15•13 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #14) > What about a manual test? Do we need one here, because we can't cover it by > automation? I would tend to say so. for FFTs IMO
Comment 16•13 years ago
|
||
There's no use spending time manually testing something that no average user will ever do.
Flags: in-litmus? → in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•