684257 - No easy way to go back to the sign in page after clicking a link in the BrowserID window

Status: RESOLVED FIXED

(Pancake Graveyard :: Native iOS Wrapper, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. launch Pancake iApp
2. logout if already signed in
3. click on Signin
4. at the bottom of the page select any of the links :
"Mozilla Labs", "terms", "privacy policy", and "learn more"

Expected: the web pages fit inside the window and have a nice "back" button to go back to signing in

Actual: web pages do not fit and you have to cancel out of the dialog and then select the Signin button

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

iOS:4.3.5 ; iPad 2 ; Staging 9022011-08:54AMPDT ; Pancake .10

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Yeah I think we either need to add basic navigation to the BrowserID window or work with them to make sure you can't escape the dialog.

Comment 3

[Shane Tomlinson [:stomlinson]]

Stefan - the entire UX is going through a redesign right now, check with bwarner and andy chung for more details.  I am proposing that we use the pushState API to be able to use browser back/forward buttons, could this address your concerns?

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Yeah if you you are not going to have explicit back buttons in the UI then we can implement basic back/forward navigation in the iOS app. I'll talk to bwarner and andy.

Comment 5

[Mardeg]

(In reply to Shane Tomlinson from comment #3)
> Stefan - the entire UX is going through a redesign right now, check with
> bwarner and andy chung for more details.  I am proposing that we use the
> pushState API to be able to use browser back/forward buttons, could this
> address your concerns?

Could you tell us the bug numbers of the redesign? I want to file a blocking bug about not having access to bookmarks within the modal dialog so I can use a password generating bookmarklet to sign in, especially since the bookmarklet was accessible when registering in the normal window.

Comment 6

[Shane Tomlinson [:stomlinson]]

Mardeg, we use GitHub issues as our bug tracker - https://github.com/mozilla/browserid/issues/.  Any issues should be filed there.

Comment 7

[Mardeg]

Sorry Shane, I got that comment just after filing bug 699003 blocking bug 692247

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moved to the iOS component. We need to add forward/back buttons to the modal webviews.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed with https://bitbucket.org/mozillapancake/pancake-ios/changeset/7845b7b6989c

Links are opened in Safari. Use multitasking to get back to pancake and finish the BrowserID login.