684362 - IonMonkey: Crash building SSA for an infinite loop

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[Sean Stangl [:sstangl]]

Comment on attachment 557955 [details] [diff] [review]
fix

Review of attachment 557955 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +707,5 @@
>  
>      current = successor;
> +
> +    // An infinite loop (for (;;) { }) will not have a successor.
> +    if (!current)

Would prefer (!successor) for clarity.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/1643eac86ad1

(re: nit, the !current .. return Ended pattern is really prevalent, it should probably actually be a helper and tail called.)