684818 - shift+tab fails on editable document after context menu is closed: enable mochitest

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: testcase

spun off bug 550338:

1. Focus the editable document.
2. Open context menu (press the applications key, shift+F10 or right click)
3. Dismiss context menu (press escape or alt key)
4. Press shift+tab
  Actual: Nothing happens.

Comment 1

[alexander :surkov (:asurkov)]

Neil's bug 550338 comment #8:
The second set of steps (5-9) look like an unrelated bug, which has to do with confusion over what should be focused in editable documents. Bug 544277 is an example of a bug related to this.

Comment 2

[James Teh [:Jamie]]

Seems to be fixed in the last try build for bug 673958.

Comment 3

[alexander :surkov (:asurkov)]

fixed by bug 673958

Comment 4

[alexander :surkov (:asurkov)]

(In reply to alexander surkov from comment #3)
> fixed by bug 673958

It's really fixed but I bet that wasn't bug 673958.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 563274 [details] [diff] [review]
patch

r=me. So which bug fixed this one?

Comment 7

[Marco Zehe (:MarcoZ)]

This sounds awfully similar to bug 550338, which *was* fixed by bug 673958, so I think this is actually a dupe of bug 550338. The later steps of bug 550338 provide this exact testcase.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Marco Zehe (:MarcoZ) from comment #7)
> This sounds awfully similar to bug 550338

Marco, this bug is spun off the bug 550338 :), in other words, I filed it to keep  keyboard navigation issue separately from disability access problems. Eventually the problem was fixed (and our focus rework is not guilty of that). 

I'll enable mochitest to make sure it won't regress.

Comment 9

[alexander :surkov (:asurkov)]

landed on inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/be9874f75bae

I disabled the test on linux since due to some reason shift + tab doesn't work on linux in this case.

Trevor, when you get some time then could you please check it and file new bug?

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/be9874f75bae