Closed Bug 684910 Opened 13 years ago Closed 13 years ago

[Aurora] - Remove 'Install as App' from site menu

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox8 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 8
Tracking Flags:
Tracking Status
firefox8 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

(Keywords: verified-beta, Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

patch 2
2.11 KB, patch
mfinkle
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
The menu item was never intended to ship with Firefox. It's just a way to test some functionality in the Nightly. This patch removes the menu item from the site menu. This patch is only destined for Aurora, not Nightly.
Attachment #558522 - Flags: review?(fabrice)
Comment on attachment 558522 [details] [diff] [review]
patch

Review of attachment 558522 [details] [diff] [review]:
-----------------------------------------------------------------

we also need to remove this line :
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/common-ui.js#183

r+ with this change
Attachment #558522 - Flags: review?(fabrice) → review+
Attached patch patch 2 — — Splinter Review 
Updated patch. Carrying Fabrice's r+ forward.

This patch is only for removing a small feature from the UI of Aurora. Requesting approval.
Assignee: nobody → mark.finkle
Attachment #558624 - Flags: review+
Attachment #558624 - Flags: approval-mozilla-aurora?
Comment on attachment 558624 [details] [diff] [review]
patch 2

Approved for releases/mozilla-aurora. Please land asap
Attachment #558624 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #558522 - Attachment is obsolete: true
We're going to track for QA verification.

Also, if status-firefox9 is fixed, can we change the status to Resolved Fixed?
Whiteboard: [qa+]
Resolving, but this is not fixed in 9. We are only removing from aurora (8) for now.
Status: NEW → RESOLVED
Closed: 13 years ago
status-firefox9: fixed → ---
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a2)Gecko/20110927
Firefox/8.0a2 Fennec/8.0a2
Device: Acer ICONIA A500
OS: Android 3.1
Keywords: verified-aurora
Status: RESOLVED → VERIFIED
Keywords: verified-aurora → verified-beta
Whiteboard: [qa+] → [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: