Closed
Bug 685127
Opened 13 years ago
Closed 5 years ago
Scroll position not remembered after "undo closed tab"
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: andreea.pod, Unassigned)
References
Details
(Keywords: polish, Whiteboard: [fennec-sessionstore][fennec 13.0b1])
Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20110905 Firefox/9.0a1 Fennec/9.0a1 Device: LG Optimus 2X Steps to reproduce: 1. Open a page and scroll down to the bottom 2. Close the page 3. Undo closed tab Expected results: The undone closed page should be reloaded and scrolled to the bottom Actual result: Page is at the top, scroll position is not remembered. Note: bug 604463 is verified fixed but it seems that only for the browsing history not for the scroll offsets also.
Comment 1•13 years ago
|
||
So it seems like the patch in bug 604463 should have taken care of this. If it's not working now, perhaps it regressed?
Reporter | ||
Comment 2•13 years ago
|
||
I tried this on few builds after the patch landed in that bug and I could reproduce it on all of them, so I guess the patch didn't fix it.
Updated•13 years ago
|
Updated•13 years ago
|
Keywords: helpwanted
Whiteboard: [fennec-sessionstore] → [fennec-sessionstore][mentor=mbrubeck@mozilla.com][good first bug]
Comment 3•13 years ago
|
||
Matt, could you add some pointers for where a new contributor should start looking to fix this?
Updated•13 years ago
|
Priority: -- → P3
Comment 4•13 years ago
|
||
This bug might actually be more complex than I thought. I'll remove the good-first-bug tag, but I can still help mentor this if someone wants to pick it up. I think the right way to fix this is to save the scroll position of the tab in the SessionStore "extData" property using SessionStore.saveTabValue: https://hg.mozilla.org/releases/mozilla-beta/file/cf0a29826586/mobile/components/SessionStore.js#l617 and then pull it out of there and re-apply it after the tab is restored.
Whiteboard: [fennec-sessionstore][mentor=mbrubeck@mozilla.com][good first bug] → [fennec-sessionstore][mentor=mbrubeck@mozilla.com]
Updated•13 years ago
|
tracking-fennec: --- → ?
Updated•13 years ago
|
tracking-fennec: ? → ---
Comment 5•12 years ago
|
||
Matt, is this still a valid bug for a new contributor to be working on? In other words, does this still apply to the Native UI, so that the work done won't be wasted?
Comment 6•12 years ago
|
||
This bug applies only to XUL Fennec, though we might need a separate bug to add the same feature to the new native Android UI.
Keywords: helpwanted
Whiteboard: [fennec-sessionstore][mentor=mbrubeck@mozilla.com] → [fennec-sessionstore]
Comment 7•12 years ago
|
||
The bug is also reproducible on: Mozilla/5.0(Android;Linux armv7l;rv:11.0a2)Gecko/20120201 Firefox/11.0a2 Fennec/11.0a2 Device:Samsung Galaxy Tab OS:Android 3.1
Updated•12 years ago
|
Whiteboard: [fennec-sessionstore] → [fennec-sessionstore][fennec 13.0b1]
Comment 8•5 years ago
|
||
Closing all opened bug in a graveyard component
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•