685347 - Context menu selections in URL bar removes focus on the URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. tap in the URL bar
2. tap again to remove the highlight and place the cursor in the URL bar
3. long tap on the URL bar to bring out the context menu
4. select Select All

Expected: everything in the URL bar is highlighted, VKB is still out, and the focus is still on the URL bar

Actual: VKB dismisses, focus is no longer on the URL bar.

Note:
Mozilla/5.0 (Android; Linux armv7I; rv9.0a1) Gecko/20110907 Firefox/9.0a1 Fennec/9.0a1

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Toshiba Thrive 3.1, HTC Flyer 2.3
With TabletUI turned on

Comment 3

[Cristian Nicolae (:xti)]

Practically there is the same result for all Awesomescreen/Context Menu options. If I tap on "Paste" option, for example, and I do not release the finger on the screen, I've noticed that in background the Awesomescreen is dismissed and the app goes to the mainview. 

--
Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110908
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Comment 4

[Cristian Nicolae (:xti)]

Is this issue related to Bug 684710?

Comment 5

[Carla Nadastean]

Bug not reproducible with:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110902
Firefox/9.0a1 Fennec/9.0a1
http://hg.mozilla.org/mozilla-central/rev/ce43a8644bc0

Bug reproducible with:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110903
Firefox/9.0a1 Fennec/9.0a1
http://hg.mozilla.org/mozilla-central/rev/472716252ea3

Possible range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ce43a8644bc0&tochange=472716252ea3

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Cristian Nicolae (:xti) from comment #4)
> Is this issue related to Bug 684710?

Very well could be (same actual result)

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

This is because of the hacky way I implemented hiding the urlbar when the user taps outside of it. Sometimes, even though the user tapped outside, we should not hide the bar.

This is a quick fix, although I think maybe I should look into a cleaner one. Perhaps we can look for an element with a particular class (like modal-block)?

Comment 8

[Martijn Wargers (dead)]

I assume the patch can be checked in, right?

Comment 10

[Ed Morley [:emorley]]

Bug number added to commit message, pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17f7d5184d5a

Comment 11

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/17f7d5184d5a

Comment 13

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110919
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2