Closed Bug 685415 Opened 13 years ago Closed 8 years ago

nsFileProtocolHandler::ReadURLFile is unnecessary on Android

Categories

(Core :: Networking: File, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Android should return NS_ERROR_NOT_AVAILABLE.
Attached patch fixSplinter Review
Assignee: nobody → m_kato
Attachment #566750 - Flags: review?(blassey.bugs)
(In reply to Makoto Kato from comment #0)
> Android should return NS_ERROR_NOT_AVAILABLE.

why?
(In reply to Brad Lassey [:blassey] from comment #2)
> (In reply to Makoto Kato from comment #0)
> > Android should return NS_ERROR_NOT_AVAILABLE.
> 
> why?

Why should we support .desktop file on Android?  .desktop is for freedesktop.org.
Comment on attachment 566750 [details] [diff] [review]
fix

Review of attachment 566750 [details] [diff] [review]:
-----------------------------------------------------------------

clearing the review until my question is answered
Attachment #566750 - Flags: review?(blassey.bugs)
(In reply to Brad Lassey [:blassey] from comment #4)
> Comment on attachment 566750 [details] [diff] [review] [diff] [details] [review]
> fix
> 
> Review of attachment 566750 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> clearing the review until my question is answered

Brad and Doug, "*.desktop" file doesn't support on Android.  This code is for .desktop file handling.  You don't answer my question why "*.desktop" file has to support on Android.

Android dekstop doesn't have url shortcut file.  So we should remove this implementation on Android.

So we should return any error on this method.  If we should support "*.desktop" file, please resolved as WONTFIX.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: