685568 - [TABLETUI] add vertical divider between tab bar and web content

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: mockup

This will help tie our tab image and action bar together nicely, particularly with websites that have darker backgrounds.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Add vertical divider between tab bar and web content

I considered parametrizing the color of the divider based on toolbar color but this will only make sense if/when we start actually theming tablet mode for gingerbread/froyo. For now, just setting the color that makes sense with our current tablet design.

Comment 2

[Matt Brubeck (:mbrubeck)]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d771ae3d3021
https://hg.mozilla.org/integration/mozilla-inbound/rev/db34d544a36b

(I was experimenting with a change to this patch and forgot to revert it before pushing, so I changed it back in a follow-up push.)

Comment 3

[Matt Brubeck (:mbrubeck)]

After consulting with Ian, we actually do want to go with the xxlarge border, so I pushed a *third* change to back out db34d544a36b:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c13a8d2c0cbb

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c13a8d2c0cbb
https://hg.mozilla.org/mozilla-central/rev/db34d544a36b
https://hg.mozilla.org/mozilla-central/rev/d771ae3d3021

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1