68561 - Mozilla build with Xlib toolkit only offers GTK+-specific options...

Status: VERIFIED FIXED

(Core Graveyard :: Cmd-line Features, defect)

Description

[Roland Mainz]

mozilla-2001-02-10-08-Mtrunk build on Linux/Solaris "offer" GTK+-specific
cmd-line options when build with --enable-toolkit=xlib:
-- snip --
% ./mozilla --help
./run-mozilla.sh ./mozilla-bin --help
MOZILLA_FIVE_HOME=.
 
LD_LIBRARY_PATH=.:/usr/local/staden/lib/solaris-binaries:/usr/local/lib:/usr/local/rvplayer5.0:/usr/local/arb/lib
     LIBRARY_PATH=.:./components
       SHLIB_PATH=.
          LIBPATH=.
       ADDON_PATH=.
      MOZ_PROGRAM=./mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
File descriptors set to 512
Usage: ./mozilla-bin [ options ... ] [URL]
       where options include:

GTK options
        --gdk-debug=FLAGS               Gdk debugging flags to set
        --gdk-no-debug=FLAGS            Gdk debugging flags to unset
        --display=DISPLAY               X display to use
        --sync          Make X calls synchronous
        --no-xshm               Don't use X shared memory extension
        --xim-preedit=STYLE
        --xim-status=STYLE
        --gtk-debug=FLAGS               Gtk+ debugging flags to set
        --gtk-no-debug=FLAGS            Gtk+ debugging flags to unset
        --g-fatal-warnings              Make all warnings fatal
        --gtk-module=MODULE             Load an additional Gtk module

Mozilla options
        -height <value>         Set height of startup window to <value>.
        -h or -help             Print this message.
        -installer              Start with 4.x migration window.
        -width <value>          Set width of startup window to <value>.
        -v or -version          Print ./mozilla-bin version.
        -CreateProfile <profile>                Create <profile>.
        -P <profile>            Start with <profile>.
        -ProfileWizard          Start with profile wizard.
        -ProfileManager         Start with profile manager.
        -SelectProfile          Start with profile selection dialog.
        -nosplash               Disable splash screen.
Type Manifest File:
/bigtmp/gisburn/mozilla-2001-02-10-08-Mtrunk/mozilla/objdir_ws6_xlib/dist/bin/components/xpti.dat
        -compose <url>          Start with messenger compose.
        -edit <url>             Start with editor.
        -mail           Start with mail.
        -addressbook            Start with the addressbook.
        -chrome <url>           Load the specified chrome.
        -jsconsole              Start with Javascript Console
        -news           Start with news.
-- snip --

Uhm... assuming this build does not use nor link agaist libGTK&co. - why are the
nGTK+-options here ??

CC: Xlib-guru "blizzard"... :-)

Comment 1

[timeless]

Attachment: separate GTK and X11 from UNIX

Comment 2

[timeless]

please review

Comment 3

[Christopher Blizzard (:blizzard)]

So the X11 only build supports --no-xshm, --xim-* --sync and --display now?

Also, this define before the X11 options is:

+#if XP_X11 || (!NO_X11 && XP_UNIX)

which says "if XP_X11 is defined or ( not NO_X11 and XP_UNIX )"

Huh?  How does that work?  To turn off X11 we define NO_X11?

Dauphin, take me away!

Comment 4

[timeless]

sorry, the line should be
+#if defined(XP_X11) || (!defined(NO_X11) && defined(XP_UNIX))

in the future i'd hope we would simply define XP_X11. for now, that will fail 
so we'll chain to the || fallthrough case, and when no_x11 is not defined and 
xp_unix is defined we conclude we're building for x11.

as for the x* stuff, if anyone has better conditions for --x*, i'll gladly use 
them.

Comment 5

[Christopher Blizzard (:blizzard)]

That double negative is scary.

Comment 6

[QA timeless]

Attachment: patch to define and use XP_X11

Comment 7

[cls]

r=cls

Comment 8

[Dan Rosen]

r=dr

Comment 9

[Christopher Blizzard (:blizzard)]

All of those --display, etc options in the X11 sections are actually still part
of GTK and I'm pretty sure that the Xlib toolkit that we have doesn't support them.

Comment 10

[timeless]

hrm.  interesting point.

John G: i haven't gotten Qt to build yet, so I haven't tried, but does Qt 
Mozilla support -display?

Blizzard: imo what i did is still an improvement even if it's slightly wrong, 
and I promise to continue to fix it as long as there are technicalities.  
Before this change, we would display those options on XP_UNIX which should 
include Qt, Xlib, and others.

The fact that Xlib and other X11 ports do not support the options should cause 
someone to file a bug report based on theit knowledge or their viewing of this 
help screen.

Comment 11

[Chris Waterson]

Hmm, is xp_core.h the right place to #define this? I thought bryner was trying
to stomp out everything in the #include directory.

Comment 12

[timeless]

Attachment: configure.in define of MOZ_X11

Comment 13

[Christopher Blizzard (:blizzard)]

So open the bug for the other options and move the gtk specific ones inside of
the define ( --disable-xshm, --display, etc )

Comment 14

[John Griggs]

Qt Mozilla supports the use of -display and, AFAIK, other X Toolkit command line
options - at least when built against the X11 version of Qt.  (I just tested
this myself with last night's nightly...)

Comment 15

[cls]

r=cls on attach 31569

Comment 16

[Scott Collins]

sr=scc

Comment 17

[Asa Dotzler [:asa]]

Are you still shooting for 0.9 on this? If so please email [e-mail]
with a status on you progress. If not please retarget against a later Milestone.
Thanks.

Comment 18

[chris hofmann]

can we live with out this?  trying to reduce noise for 0.9..

Comment 19

[timeless]

I think that we can do this, especially if someone sr= and a='s bug 20196 which 
should alleviate blizzard's concern.

Comment 20

[Dan Rosen]

I'd like to see this bug get fixed ASAP in 0.9.1, but I don't personally think
this is in any way necessary for 0.9... It's not worth even the most minimal
risk it could pose, this far into the tree closure. I'd suggest taking it off of
chofmann's radar, honestly.

Love,
dr

Comment 21

[chris hofmann]

go into 0.9.1 when the tree opens Wed/Thur and we can revisit taking this
on the branch if its worth the time and effort.   thanks

Comment 22

[timeless]

fix checked in. requesting pardon in a few days for 0.9 branch.
This makes --help output more accurate for various x11 and non x11 ports and 
should have no risk.

Comment 23

[Roland Mainz]

Uhm... is there a way to implement this in a way that _multiple_ toolkits can be
build and users chooses his/her preferred one at cmd-line (see bug 76201 -
"allow building of multiple widget/gfx ports") ?

Comment 24

[Dan Rosen]

Roland: 76201 will likely spin-off several polish bugs like that which you
mention. If you want to pre-empt that, I'd suggest filing a new bug and have it
depend on 76201.

Comment 25

[sairuh (rarely reading bugmail)]

rubberstamping.