Closed
Bug 685788
Opened 13 years ago
Closed 13 years ago
Test for bug 593174 conceals its location after it's done
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.37 KB,
patch
|
ted
:
review+
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
My patch in bug 668728 requires that when each test is finished, its location won't change. The test for bug 593174 breaks this invariant, by using history.replaceState. I have a simple patch to fix this.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 559385 [details] [diff] [review] Patch (v1) Review of attachment 559385 [details] [diff] [review]: ----------------------------------------------------------------- This looks sane, but you'd probably be better off having the original test author review this.
Attachment #559385 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #559385 -
Flags: review?(justin.lebar+bug)
|
||
Comment 3•13 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #0) > My patch in bug 668728 requires that when each test is finished, its > location won't change. It's not a problem if the test fails (e.g. throws an exception) and leaves the location different than it was initially?
|
|
||
Updated•13 years ago
|
Attachment #559385 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c53b5ca8fde3
Flags: in-testsuite+
Target Milestone: --- → mozilla9
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c53b5ca8fde3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•