685798 - Node.parentElement not implemented

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[bugzilla33]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

1. open testcase
2. click TEST button


Actual results:

Node.parentElement not implemented


Expected results:

alerts: HTMLHtmlElement, null

Comment 1

[bugzilla33]

Attachment: testcase

Comment 2

[bugzilla33]

Note: document.documentElement.parentElement MUST alerts null unlike document.documentElement.parentNode

Comment 3

[bugzilla33]

IE, Chrome, Safari, Opera and Konqueror support parentElement

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(Opera at least doesn't seem to support parentElement in all the nodes. Chrome does. Don't know about others)

Comment 5

[Anne (:annevk)]

Opera has an open bug on moving parentElement elsewhere. We are waiting on feedback from Gecko (or an implementation) before moving ahead.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 7

[Mounir Lamouri (:mounir)]

Comment on attachment 559443 [details] [diff] [review]
patch

Review of attachment 559443 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/test/test_bug685798.html
@@ +35,5 @@
> +is(df.firstChild.firstChild.parentElement, df.firstChild,
> +   "Text node's parent should be element.");
> +
> +is(document.createTextNode("foo").parentElement, null,
> +   "Text node shouldn't have parent element.");

The test isn't clear: is it because it is a text node or because it is out of any document and has no parent?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I should be clear in the context it is in.
But I can change the text.

Comment 9

[Alex Vincent [:WeirdAl]]

We already have a bug on file for this...

Comment 10

[Boris Zbarsky [:bzbarsky]]

Ms2ger, you planning to land that patch?  ;)

Comment 11

[Boris Zbarsky [:bzbarsky]]

Actually, reopening this bug, since this patch is better than the old one.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 559443 [details] [diff] [review]
patch

Should the new prop go at the end of the interface to reduce the chance of people running into vtable issues?  Maybe it doesn't matter...

You need to rev the iids of all interfaces inheriting from nsIDOMNode.  Use http://people.mozilla.org/~sfink/uploads/update-uuids for that.

r=me with the latter fixed and the former at least considered.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +iid updates

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/569a45bfb71c
http://hg.mozilla.org/mozilla-central/rev/5eba835c23a7

Comment 16

[Eric Shepherd [:sheppy]]

Documentation written:

https://developer.mozilla.org/en/DOM/Node.parentElement

Updated:

https://developer.mozilla.org/en/DOM/Node

Also listed on Firefox 9 for developers.